Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for modelscope gradio #44

Merged
merged 25 commits into from
Mar 7, 2024
Merged

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Feb 28, 2024

Description

This pr implements the presentation of the gradio interface.
For example,
run python examples/conversation/conversation.py will chat in the terminal interface,
run as_studio examples/conversation/conversation.py will launch a studio interface.
Usage:
run as_studio path/to/your/script.py
Remark:
There should be a main() function in your script.py which is got run

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@qbc2016 qbc2016 requested a review from rayrayraykk February 28, 2024 10:16
@rayrayraykk
Copy link
Collaborator

rayrayraykk commented Feb 29, 2024

Please add the following codes in setup.py:

setuptools.setup(
    # ... 
    entry_points={
        'console_scripts': [
            'agentscope_ui=agentscope.web_ui.app:main',
        ],
    },
    # ... 
)

So that the user can run with shorter commands agentscope_ui --script ooxx

@qbc2016 qbc2016 changed the title [WIP]support for gradio support for gradio Mar 5, 2024
@rayrayraykk rayrayraykk requested a review from DavdGao March 5, 2024 06:27
@rayrayraykk rayrayraykk changed the title support for gradio support for modelscope gradio Mar 5, 2024
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/agentscope/agents/user_agent.py Outdated Show resolved Hide resolved
src/agentscope/web_ui/utils.py Outdated Show resolved Hide resolved
src/agentscope/web_ui/utils.py Outdated Show resolved Hide resolved
src/agentscope/web_ui/utils.py Outdated Show resolved Hide resolved
src/agentscope/web_ui/app.py Outdated Show resolved Hide resolved
src/agentscope/web_ui/app.py Outdated Show resolved Hide resolved
@rayrayraykk
Copy link
Collaborator

Please check the usability in win OS, and other part looks good to me.

Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in the future we should merge all web UI into one web interface.

@rayrayraykk rayrayraykk merged commit 714a758 into modelscope:main Mar 7, 2024
2 checks passed
@qbc2016 qbc2016 deleted the dev_web_ui branch August 15, 2024 09:02
myh-0521 pushed a commit to myh-0521/agentscope that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants