-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix list-src,doc,examples for >= 6.8.0 #880
base: master
Are you sure you want to change the base?
Conversation
@Kidev was there a case that needed your changes that I am reverting in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it did something at some point, maybe for the weird 6.7 versions. I'm not sure if there are any tests on those, but there should be.
Anyway it may just be an artifact of a previous version, if no tests fail it should be good hopefully
Maybe your mystery case works either way, i.e. category = "qt" and extension = None. All checks passed. |
The command "aqt list-qt all_os wasm --modules 6.7.3 wasm_singlethread" works before and after this change.
@Kidev - The command "aqt list-qt all_os wasm" fails to find 6.7.x before and after this change:
|
This is expected behavior, there is no "all_os" prior to 6.7 |
Does it still displays extensions like qtpdf in relevant archs? |
No, it should find 6.7.0, 6.7.1, 6.7.2, 6.7.3 which are all in https://download.qt.io/online/qtsdkrepository/all_os/wasm/ |
yes
|
6.7 are in both folders? Qt's team confusemaxxing right now The 6.7 have some serious quirks, called it the liminal Qt version |
This resolves #879