-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WASM #846
Merged
Merged
Fix WASM #846
Changes from 6 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
de06f45
Rewrite WASM support
Kidev 7ec6970
Add WASM tests to CI, update CI to test more the latest versions, add…
Kidev 1df829a
Fix some mistakes, typos, moved emsdk version function into BuildJob
Kidev cacabe8
Fix issue related to extensions interfering with wasm on 6.8+
Kidev 11470f9
Fix tests
Kidev 73bc8ad
Remove dep on Version in CI
Kidev 77dff51
Remove safety before patch
Kidev 5d80b7c
handle cases where extensions don't exist.
tsteven4 001bbc8
for --long-modules assume extension doesn't exist on download error.
tsteven4 4408ba6
for --modules assume extension doesn't exist for download failures.
tsteven4 c6955a6
reformat with black
tsteven4 dfc1d97
fix flake8 regression that doesn't occur locally.
tsteven4 c8ec8b8
Merge branch 'master_upstream' into wasm
Kidev 44c7762
Fix autodesktop by also updating the OS when searching for a valid de…
Kidev c40af54
Fix extension issue, reduce the possible retry for getting extensions…
Kidev 0008f42
Fix CI asking for msvc2019 on 6.8+ but its no longer supported
Kidev 592f875
Make CI use C++20 and MSVC2022
Kidev 3f108bc
Fix linux build
Kidev 1aa5216
Update runners to windows-2022
jdpurcell 6e785f0
Fix patching
jdpurcell 356a2b8
Add back the semantic version changes to prevent crashes, add tests f…
Kidev bbaa833
Update checks
Kidev 29358b1
Cast 'https://mirrors.ustc.edu.cn' to the shadow realm
Kidev 1a52e5f
Again
Kidev 7f695c4
Update settings.ini
Kidev 07ff4ce
Update settings.ini
Kidev b92d40f
Update settings.ini
Kidev 2c7ba14
Remove one_rep on silent
Kidev b734cdd
Update settings.ini
Kidev 7a2a41b
Restore master settings, remove hash check
Kidev 2288b1d
ci: Use specific mirror
jdpurcell 3568115
Re enable hash checking
Kidev 7cde90d
Treat read timeout error during download as connection error
jdpurcell de6e325
Merge branch 'master' into wasm
Kidev bbd31a9
Add test for modules in WASM with autodesktop
Kidev 2e8abc2
Fix format
Kidev f014c69
Fix test
Kidev 06a5098
Make '--autodesktop' trigger its own install process, and test it
Kidev aad5871
Fix older autodesktop tests
Kidev 37ae2fa
Add mock update files for 680 wasm, add test for wasm 680 autodesktop
Kidev 44f1a90
Passes the additional tests
Kidev 84fad94
Fix format
Kidev f9f1417
Improve coverage, fix format
Kidev 93f05d0
Fix tests and improve logging or install
Kidev b14f120
Fix format
Kidev 0cd24a0
Merge branch 'master' into wasm
Kidev c9451c3
Fix regression in other tests
Kidev 4dbb72f
Use flavor
Kidev eca7ef6
Fix line len
Kidev a46f3a7
Fix codeql
Kidev 9078341
Fix list-qt for WASM arch on 6.5.x and 6.6.x, restore to original dow…
Kidev 0343d61
Merge branch 'master' into wasm
Kidev a5a075b
Fix test error
Kidev 08328f2
Revert ci settings URL as it is never used by clients, only in CI
Kidev 3987df3
Add comment for clarity in ci/settings.ini
Kidev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,17 @@ | |
|
||
|
||
class BuildJob: | ||
|
||
EMSDK_FOR_QT = { | ||
"6.2": "2.0.14", | ||
"6.3": "3.0.0", | ||
"6.4": "3.1.14", | ||
"6.5": "3.1.25", | ||
"6.6": "3.1.37", | ||
"6.7": "3.1.50", | ||
"6.8": "3.1.56", | ||
} | ||
|
||
def __init__( | ||
self, | ||
command, | ||
|
@@ -35,7 +46,7 @@ def __init__( | |
is_autodesktop: bool = False, | ||
tool_options: Optional[Dict[str, str]] = None, | ||
check_output_cmd: Optional[str] = None, | ||
emsdk_version: str = "[email protected]", | ||
emsdk_version: str = "[email protected]", # did not change for safety, created func self.emsdk_version() | ||
autodesk_arch_folder: Optional[str] = None, | ||
): | ||
self.command = command | ||
|
@@ -102,6 +113,24 @@ def mingw_tool_name(self) -> str: | |
else: | ||
return "tools_mingw" | ||
|
||
def emsdk_version(self) -> str: | ||
return BuildJob.emsdk_version_for_qt(self.qt_version) | ||
|
||
@staticmethod | ||
def emsdk_version_for_qt(version_of_qt: str) -> str: | ||
qt_major_minor = ".".join(version_of_qt.split(".")[:2]) | ||
|
||
if qt_major_minor in BuildJob.EMSDK_FOR_QT: | ||
return BuildJob.EMSDK_FOR_QT[qt_major_minor] | ||
|
||
# Find the latest version using string comparison | ||
latest_version = "0.0" | ||
for version in BuildJob.EMSDK_FOR_QT.keys(): | ||
if version > latest_version: | ||
latest_version = version | ||
|
||
return BuildJob.EMSDK_FOR_QT[latest_version] | ||
|
||
|
||
class PlatformBuildJobs: | ||
def __init__(self, platform, build_jobs): | ||
|
@@ -111,7 +140,7 @@ def __init__(self, platform, build_jobs): | |
|
||
python_versions = ["3.12"] | ||
|
||
qt_versions = ["6.5.3"] | ||
qt_versions = ["6.8.1"] | ||
|
||
linux_build_jobs = [] | ||
linux_arm64_build_jobs = [] | ||
|
@@ -239,6 +268,22 @@ def __init__(self, platform, build_jobs): | |
mingw_variant="win64_mingw900") | ||
) | ||
|
||
# WASM post 6.7.x | ||
linux_build_jobs.append( | ||
BuildJob("install-qt", "6.7.3", "all_os", "wasm", "wasm_multithread", "wasm_multithread", | ||
is_autodesktop=True, emsdk_version=f"sdk-{BuildJob.emsdk_version_for_qt("6.7.3")}-64bit", autodesk_arch_folder="gcc_64") | ||
) | ||
for job_queue, host, desk_arch, target, qt_version in ( | ||
(linux_build_jobs, "all_os", "gcc_64", "wasm", qt_versions[0]), | ||
(mac_build_jobs, "all_os", "clang_64", "wasm", qt_versions[0]), | ||
(windows_build_jobs, "all_os", "mingw_64", "wasm", qt_versions[0]), | ||
): | ||
for wasm_arch in ("wasm_singlethread", "wasm_multithread"): | ||
job_queue.append( | ||
BuildJob("install-qt", qt_version, host, target, wasm_arch, wasm_arch, | ||
is_autodesktop=True, emsdk_version=f"sdk-{BuildJob.emsdk_version_for_qt(qt_version)}-64bit", autodesk_arch_folder=desk_arch) | ||
) | ||
|
||
# mobile SDK | ||
mac_build_jobs.extend( | ||
[ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The category handling is a bit different for >= 6.8.0 non-wasm, category is now assumed to be qt in that case. category is either tools or qt. Is there any case where the directory component is tools{major}_{ver}{ext}, either before or after 6.8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This return is there for the legacy versions. For Qt 6.8 non-WASM, this is returned:
All tests pass with this
to_folder
, older and newer versions of Qt, WASM of not