Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoSec convert Command Update #2702

Merged
merged 14 commits into from
Jul 31, 2024
Merged

GoSec convert Command Update #2702

merged 14 commits into from
Jul 31, 2024

Conversation

charleshu-8
Copy link
Contributor

  • Update GoSec convert command to accept corresponding OHDF Converters updated mapper.
  • Updates to command.

@charleshu-8 charleshu-8 added bug Something isn't working enhancement New feature or request labels Jul 2, 2024
@charleshu-8 charleshu-8 self-assigned this Jul 2, 2024
@charleshu-8 charleshu-8 marked this pull request as ready for review July 2, 2024 18:15
Amndeep7
Amndeep7 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until a new release of HDF Converters is pushed out.

@charleshu-8 charleshu-8 marked this pull request as draft July 8, 2024 17:14
@charleshu-8 charleshu-8 marked this pull request as ready for review July 8, 2024 17:15
@charleshu-8 charleshu-8 marked this pull request as draft July 9, 2024 17:03
@charleshu-8
gosec mapper update
4dd10b4 
Signed-off-by: Charles Hu <[email protected]>
@charleshu-8
Sample change
1a80c05 
Signed-off-by: Charles Hu <[email protected]>
@charleshu-8 charleshu-8 marked this pull request as ready for review July 26, 2024 14:16
Amndeep7
Amndeep7 requested changes Jul 28, 2024
View reviewed changes
Copy link
Contributor

@Amndeep7 Amndeep7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise, this is good to merge once the other PR is merged; however, we will need to merge in the changes to the sample output files that happened in the corresponding HDF Converters PR.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarCloud

@Amndeep7 Amndeep7 merged commit e867fb1 into main Jul 31, 2024
12 of 13 checks passed
@Amndeep7 Amndeep7 deleted the gosecMapperFix branch July 31, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Amndeep7 requested changes

Assignees

@charleshu-8 charleshu-8

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleshu-8 @Amndeep7