Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary desc statements #114

Merged
merged 17 commits into from
Oct 18, 2024
Merged

Removed unnecessary desc statements #114

merged 17 commits into from
Oct 18, 2024

Conversation

karikarshivani
Copy link
Contributor

@karikarshivani karikarshivani commented Oct 15, 2024

For tests such as:

 desc 'This control is not applicable'
 describe 'This control is not applicable' do
   skip 'This control is not applicable'
 end

desc statements do not make a difference and may cause issues with inspec json and delta.
Controls containing unnecessary desc statements have been updated to:

 describe 'This control is not applicable' do
   skip 'This control is not applicable'
 end

Thanks to @ejaronne for running this locally! Attaching reports here for reference:

Screenshot 2024-10-18 at 10 00 59 AM

@karikarshivani karikarshivani self-assigned this Oct 15, 2024
Copy link
Contributor

@ejaronne ejaronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks! (See the personal runs internally, of main vs this branch to show that it doesn't throw a problem)

@karikarshivani karikarshivani marked this pull request as ready for review October 18, 2024 13:55
Copy link
Contributor

@DMedina6 DMedina6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved!

@karikarshivani karikarshivani merged commit 88c6e23 into main Oct 18, 2024
1 check passed
@karikarshivani karikarshivani deleted the remove-desc branch October 18, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants