-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLRU added for git plugin #750
Draft
aamohd
wants to merge
2
commits into
main
Choose a base branch
from
aamohd/git-cache-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ use crate::data::*; | |
|
||
use anyhow::Context; | ||
use anyhow::Result; | ||
use clru::CLruCache; | ||
use gix::bstr::ByteSlice; | ||
use gix::diff::blob::intern::InternedInput; | ||
use gix::diff::blob::sink::Counter; | ||
|
@@ -18,13 +19,17 @@ use gix::traverse::commit::simple::CommitTimeOrder; | |
use gix::ObjectId; | ||
use gix::Repository; | ||
use jiff::Timestamp; | ||
use std::num::NonZero; | ||
use std::path::Path; | ||
use std::path::PathBuf; | ||
use std::sync::LazyLock; | ||
use std::sync::Mutex; | ||
|
||
/// used to cache all of the `RawCommit` from the last repo/HEAD combination analyzed by this | ||
/// plugin | ||
type GitRawCommitCache = Option<(PathBuf, ObjectId, Vec<RawCommit>)>; | ||
type GitRawCommitCache = CLruCache<(PathBuf, ObjectId), Vec<RawCommit>>; | ||
static CACHE: LazyLock<Mutex<GitRawCommitCache>> = | ||
LazyLock::new(|| Mutex::new(CLruCache::new(NonZero::new(1).unwrap()))); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The point of this PR is to make the |
||
|
||
/// retrieve a handle to the git repo at this path, as well as determine the commit hash of | ||
/// HEAD | ||
|
@@ -108,6 +113,7 @@ where | |
{ | ||
let commit_walker = get_commit_walker(repo, head_commit)?; | ||
let commits = walk_commits(repo, commit_walker, &get_raw_commit, None)?; | ||
// let raw_commits: GitRawCommitCache = | ||
Ok((repo_path.as_ref().to_path_buf(), head_commit, commits)) | ||
} | ||
|
||
|
@@ -122,24 +128,22 @@ pub fn get_all_raw_commits<P>(repo_path: P) -> Result<Vec<RawCommit>> | |
where | ||
P: AsRef<Path>, | ||
{ | ||
// used to cache all of the RawCommits from the last repository analyzed | ||
static ALL_RAW_COMMITS: Mutex<GitRawCommitCache> = Mutex::new(None); | ||
|
||
let (repo, head_commit) = initialize_repo(repo_path.as_ref())?; | ||
let mut cache = ALL_RAW_COMMITS.lock().unwrap(); | ||
let mut cache = CACHE.lock().unwrap(); | ||
|
||
// if there is a value in cache, and it is the same repo with the same HEAD commit, then we can use the | ||
// cached value | ||
if let Some(cached_value) = cache.as_ref() { | ||
if cached_value.0 == repo_path.as_ref().to_path_buf() && cached_value.1 == head_commit { | ||
return Ok(cached_value.2.clone()); | ||
} | ||
if let Some(cached_value) = cache.get_mut(&(repo_path.as_ref().to_path_buf(), head_commit)) { | ||
return Ok(cached_value.clone()); | ||
} | ||
|
||
// otherwise the cache needs to be updated with the data from this repo_path/HEAD combination | ||
let updated_value = get_all_raw_commits_inner(&repo, repo_path.as_ref(), head_commit)?; | ||
let raw_commits = updated_value.2.clone(); | ||
*cache = Some(get_all_raw_commits_inner(&repo, repo_path, head_commit)?); | ||
cache.put( | ||
(repo_path.as_ref().to_path_buf(), head_commit), | ||
raw_commits.clone(), | ||
); | ||
Ok(raw_commits) | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that the
clru
crate is better for this thanlru
? https://docs.rs/lru/latest/lru/