T10924: Add some ApprovedRevs settings #5269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phabricator task: https://phabricator.miraheze.org/T10924
|
$egApprovedRevsShowNotApprovedMessage is missing |
|
CI doesn't like it when no string on help, some other stuff related to default permissions need to be looked at before this can be merged. |
|
overridedefault should be set to the values at https://github.com/wikimedia/mediawiki-extensions-ApprovedRevs/blob/master/extension.json |
The description for overridedefault says (https://github.com/miraheze/mw-config/blob/29506b4a0eee29ec3549bc94c34c6475b355a753/ManageWikiSettings.php#L11) "a string/array override default when no existing value exist." If I'm understanding this correctly, this means ManageWiki will use this value if one has not been configured by the wiki's bureaucrats. I've changed this to the defaults at https://github.com/wikimedia/mediawiki-extensions-ApprovedRevs/blob/75e657c4533c51078b10735ec0e2366dc099e051/extension.json. This should make it so that there are no changes to wikis' existing ApprovedRevs config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator task: https://phabricator.miraheze.org/T10924