Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend unlimted offset for query iterator(#2418) #2419

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Dec 9, 2024

related: #2418
pr: #2420

@MrPresent-Han MrPresent-Han force-pushed the extend-iterator-offset branch 2 times, most recently from 287e262 to f957c1f Compare December 9, 2024 09:11
@MrPresent-Han MrPresent-Han force-pushed the extend-iterator-offset branch from f957c1f to 53960dc Compare December 9, 2024 09:33
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@XuanYang-cn XuanYang-cn added PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch and removed approved labels Dec 9, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 9, 2024
related: #2418
pr: #2419

Signed-off-by: MrPresent-Han <[email protected]>
Co-authored-by: MrPresent-Han <[email protected]>
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels Dec 10, 2024
@XuanYang-cn XuanYang-cn self-requested a review December 10, 2024 11:03
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6feeaf3 into milvus-io:master Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants