Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: some updates for ci #251

Merged
merged 1 commit into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ pull_request_rules:
conditions:
- base=master
- "status-success=Build and test AMD64 Ubuntu 18.04"
- "status-success=Build and test AMD64 Ubuntu 22.04"
- "status-success=Build and test AMD64 CentOS 7"
- "status-success=Build and test AMD64 Fedora 38"
- "status-success=Build and test AMD64 Fedora 39"
- "status-success=Build and test macOS 11"
- "status-success=Build and test windows"
actions:
label:
add:
Expand All @@ -15,6 +20,13 @@ pull_request_rules:
- or:
- "check-failure=Build and test AMD64 Ubuntu 18.04"
- "check-failure=Build and test AMD64 CentOS 7"
- "check-failure=Build and test AMD64 Ubuntu 18.04"
- "check-failure=Build and test AMD64 Ubuntu 22.04"
- "check-failure=Build and test AMD64 CentOS 7"
- "check-failure=Build and test AMD64 Fedora 38"
- "check-failure=Build and test AMD64 Fedora 39"
- "check-failure=Build and test macOS 11"
- "check-failure=Build and test windows"
actions:
label:
remove:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ jobs:
image: centos:7
key: c7
- distro: Fedora
version: 36
image: fedora:36
key: fc36
version: 38
image: fedora:38
key: fc38
- distro: Fedora
version: 37
image: fedora:37
key: fc37
version: 39
image: fedora:39
key: fc39
env:
CCACHE_DIR: ${{ github.workspace }}/.ccache
CCACHE_COMPILERCHECK: content
Expand Down
13 changes: 7 additions & 6 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,19 @@ Please file an [issue](https://github.com/milvus-io/milvus-sdk-cpp/issues/new) i
# Supported Platforms
- Linux
- macOS
- Windows

# Build C++ SDK with your Linux

## Setup development environment
Currently, we tested the below platform and compilers for developing Milvus C++ SDK.

| Platform | Version | Compiler Tested | Support |
| -------- | ------------ | --------------- | ----------------------------- |
| Linux | Ubuntu 18.04 | GCC 7.0.0 | Full (Compile, Lint, Testing) |
| Linux | Ubuntu 20.04 | GCC 9.3.0 | Full (Compile, Lint, Testing) |
| Linux | Fedora 34/35 | GCC 11.2 | Compile, Testing |
| Linux | CentOS 7 | GCC 4.8.5 | Compile, Testing |
| Platform | Version | Compiler Tested | Support |
| -------- | ------------ | -------------------- | ----------------------------- |
| Linux | Ubuntu 18.04 | GCC 7.0.0 | Full (Compile, Lint, Testing) |
| Linux | Ubuntu 20.04 | GCC 9.3.0 | Full (Compile, Lint, Testing) |
| Linux | Fedora 38/39 | GCC 11.2 | Compile, Testing |
| Linux | CentOS 7 | GCC7 (devtoolset-7) | Compile, Testing |

### Clone the code

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ To contribute to this project, please read our [contribution guidelines](https:/

The following collection shows Milvus versions and recommended milvus-cpp-sdk versions:

|Milvus version| Recommended SDK version |
| Milvus version | Recommended SDK branch |
|:-----:|:-----:|
| 2.0.x | 2.0.0 |
| 2.3.x | main |


## Installation
Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/CalcDistanceArguments.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <vector>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/CollectionDesc.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <vector>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/CollectionInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <vector>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/CollectionSchema.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <unordered_set>
#include <vector>
Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/CollectionStat.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <unordered_map>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/ConnectParam.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>

namespace milvus {
Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/Constants.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
// limitations under the License.

#pragma once
#include <cstdint>
#include <string>

namespace milvus {
Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/FieldSchema.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <map>
#include <string>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/HybridTimestamp.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once
#include <chrono>
#include <cstdint>

#include "Constants.h"

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/IDArray.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <vector>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/IndexDesc.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <memory>
#include <string>
#include <unordered_map>
Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/IndexState.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>

namespace milvus {
Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/PartitionInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <vector>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/QueryArguments.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <set>
#include <string>

Expand Down
1 change: 1 addition & 0 deletions src/include/milvus/types/SegmentInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

#pragma once

#include <cstdint>
#include <string>
#include <vector>

Expand Down