Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Rename duplicated compaction task command #317

Merged
merged 1 commit into from
Sep 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enhance: Rename duplicated compaction task command
Duplicated method name from different embed struct causing command
failed to work

Signed-off-by: Congqi Xia <[email protected]>
congqixia committed Sep 30, 2024

Verified

This commit was signed with the committer’s verified signature.
commit fc01e0e188bd175ef51fd329540654ddc6d53d0d
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
@@ -121,6 +121,7 @@ require (
github.com/rs/xid v1.2.1 // indirect
github.com/sirupsen/logrus v1.8.1 // indirect
github.com/soheilhy/cmux v0.1.5 // indirect
github.com/stretchr/objx v0.5.0 // indirect
github.com/tmc/grpc-websocket-proxy v0.0.0-20201229170055-e5319fda7802 // indirect
github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
github.com/ugorji/go/codec v1.2.11 // indirect
4 changes: 2 additions & 2 deletions states/etcd/remove/compaction_task.go
Original file line number Diff line number Diff line change
@@ -20,8 +20,8 @@ type CompactionTaskParam struct {
Run bool `name:"run" default:"false" desc:"flag to control actually run or dry"`
}

// CompactionTaskCommand is the command function to remove compaction task.
func (c *ComponentRemove) CompactionTaskCommand(ctx context.Context, p *CompactionTaskParam) error {
// RemoveCompactionTaskCommand is the command function to remove compaction task.
func (c *ComponentRemove) RemoveCompactionTaskCommand(ctx context.Context, p *CompactionTaskParam) error {
compactionTasks, err := common.ListCompactionTask(ctx, c.client, c.basePath, func(task *models.CompactionTask) bool {
if p.CompactionType != task.GetType().String() {
return false