fix: check whether lastFocusedList is valid when assigned #238765
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234791
Steps to Reproduce
Issue
The problem happens when you pick a color from the modal. When the color is selected, the modal briefly grabs focus, which triggers an
onDidFocus
event. This event updates_lastFocusedWidget
inlistService
, which is then mistakenly used in the functiongetSelectedInstances
. The function assumes thatlastFocusedList
is always aTerminalTabList
, which isn't always true.Fix
The fix ensures
listService.lastFocusedList
is only used when it's aTerminalTabList
, not when other widgets like theQuickInputTree
are focused.Let me know if any adjustments are needed!