Separate Jupyter session creator for raw and Jupyter #13439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
separateJupyterSessionCreatorForRawAndJupyter
branch
from
03c2094 to
90b1168
Compare
DonJayamanne
commented
May 2, 2023
| import { PythonExtensionNotInstalledError } from '../../../platform/errors/pythonExtNotInstalledError'; | ||
|
|
||
| @injectable() | ||
| export class JupyterServerConnector implements IJupyterServerConnector { |
There was a problem hiding this comment.
These are not the final names and final classes, the primary goal is to break down larger components into smaller ones , this way re-factoring this would be simpler and its easier
Right now there's a lot of inheritance and coupling
DonJayamanne
commented
May 2, 2023
| * Responsible for starting a Jupyter server. It's a base class because we used | ||
| * to have a host and a guest version. Host version could be consolidated into this class now. | ||
| */ | ||
| export class JupyterExecutionBase implements IJupyterExecution { |
There was a problem hiding this comment.
Deleted this base class, was inherited in one class
DonJayamanne
commented
May 2, 2023
|
|
||
| /** | ||
| * Jupyter server implementation that uses the JupyterExecutionBase class to launch Jupyter. | ||
| */ | ||
| @injectable() | ||
| export class HostJupyterExecution extends JupyterExecutionBase implements IJupyterExecution { | ||
| export class HostJupyterExecution implements IJupyterExecution { |
There was a problem hiding this comment.
Merged base class code into this class, base class was not used anywhere else, hence no point of the base class
DonJayamanne
commented
May 2, 2023
| @@ -56,7 +57,11 @@ export function registerTypes(serviceManager: IServiceManager, _isDevMode: boole | |||
| JupyterUriProviderRegistration | |||
| ); | |||
| serviceManager.addSingleton<IJupyterServerUriStorage>(IJupyterServerUriStorage, JupyterServerUriStorage); | |||
| serviceManager.addSingleton<INotebookProvider>(INotebookProvider, NotebookProvider); | |||
| serviceManager.addSingleton<IJupyterServerConnector>(IJupyterServerConnector, JupyterServerConnector); | |||
roblourens
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12832