Multiple Webview Tabs #2093
Multiple Webview Tabs #2093
Conversation
ScottCarda-MS
requested review from
billti,
idavis,
minestarks and
sezna
as code owners
| @@ -332,6 +332,7 @@ export function updateCircuitPanel( | |||
| calculating?: boolean; | |||
| }, | |||
| ) { | |||
| const panelId = params?.operation?.operation || projectName; | |||
There was a problem hiding this comment.
In the rare case where two operations from two different programs have the same name, the panel IDs won't be unique. But I'm okay with that. The panel titles look identical to the user anyway, so if they really want to differentiate the panels, they can use different operation names.
| @@ -14,7 +14,7 @@ export async function showDocumentationCommand(extensionUri: Uri) { | |||
|
|
|||
| // Reveal panel and show 'Loading...' for immediate feedback. | |||
| sendMessageToPanel( | |||
| "documentation", // This is needed to route the message to the proper panel | |||
| { panelType: "documentation", id: "" }, // This is needed to route the message to the proper panel | |||
There was a problem hiding this comment.
Though "" technically works, I dislike the use of empty string to mean "none". Making id an optional field and simply not passing it in here would make the semantics a bit clearer I think.
| ? "Q# Documentation" | ||
| : type == "estimates" | ||
| ? "Q# Estimates" | ||
| : `${id} ${panelTypeToTitle[type]}`; |
There was a problem hiding this comment.
I think a title like Q# Histogram - NameOfFile.qs would look more consistent with the other tabs.
| props: CircuitProps; | ||
| }; | ||
|
|
||
| type DocumentationState = { | ||
| viewType: "documentation"; | ||
| panelId: string; |
There was a problem hiding this comment.
Do you really need to pass in panelId for Documentation and Estimates, since they don't actually have distinct panel IDs?
Instead of always consuming the last Q# webview tab, open a new webview tab when activated with a new operation. Activation with the same operation will still consume/update the last webview for that operation. Works on circuit and histogram panels.