"Import External Q# Package" VS Code command palette command #2079
Conversation
sezna
requested review from
billti,
idavis,
minestarks,
DmitryVasilevsky and
swernli
as code owners
| const projectChoices: Array<{ name: string; ref: LocalProjectRef }> = []; | ||
|
|
||
| projectFiles.forEach((file) => { | ||
| const dirName = file.path.slice(0, -"/qsharp.json".length); | ||
| const relPath = getRelativeDirPath(qsharpJsonDir.path, dirName); | ||
| projectChoices.push({ | ||
| name: dirName.slice(dirName.lastIndexOf("/") + 1), | ||
| ref: { | ||
| path: relPath, | ||
| }, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Would look more natural to write this as a .map() in my opinion.
| JSON.stringify(manifestObj, null, 2), | ||
| ); | ||
| if (!(await vscode.workspace.applyEdit(edit))) { | ||
| vscode.window.showErrorMessage( |
There was a problem hiding this comment.
| vscode.window.showErrorMessage( | |
| await vscode.window.showErrorMessage( |
| const dirName = file.path.slice(0, -"/qsharp.json".length); | ||
| const relPath = getRelativeDirPath(qsharpJsonDir.path, dirName); | ||
| projectChoices.push({ | ||
| name: dirName.slice(dirName.lastIndexOf("/") + 1), |
There was a problem hiding this comment.
I can't find any bugs from just reading the code, but the / separator has me wondering if this has been tested on Windows (desktop and web)? LMK if you want me to give it a spin on my laptop.
-- in my experience, Windows browser, Windows desktop, and linux/mac browser/desktop all have unique path handling concerns. And even just in the browser: the playground, the test FS, and the local FS all show up as different virtual filesystems with different quirks. So I've become very distrustful of filesystem code... forgive me.
There was a problem hiding this comment.
FWIW, this is previously-existing code from Bill's implementation, I just moved it elsewhere. It's been live for a while now, and I believe all paths in the vscode APIs are normalized -- I can't find the exact docs but this hints at it https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.d.ts#L1466
This PR formalizes the "registry" md document into a JSON file, and then adds a command palette command which consumes it. This will hopefully increase discoverability of the project system, and formalizes our listing of known libraries a bit more.
Screen.Recording.2024-12-27.at.10.18.05.AM.mov