Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly reset apiZone instead of everything #34265

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 9, 2025

Also simplify zones api a bit and improve test coverage.

This comment has been minimized.

@dgozman dgozman force-pushed the chore-keep-all-zone-data branch from 53c539a to f68ce88 Compare January 9, 2025 21:22
@dgozman dgozman changed the title chore: keep all zone data in Zone.run() chore: explicitly reset apiZone instead of everything Jan 9, 2025

This comment has been minimized.

Also simplify zones api a bit and improve test coverage.
@dgozman dgozman force-pushed the chore-keep-all-zone-data branch from f68ce88 to 6c0e9e9 Compare January 10, 2025 19:04
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy @smoke @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18

37568 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants