docs(test-assertions-js): add base matcher mutability caution note #34155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
reviewed
Dec 30, 2024
| @@ -308,6 +308,18 @@ test('amount', async () => { | |||
| }); | |||
| ``` | |||
|
|
|||
| Note that `expect.extend()` is mutable, so overriding base matchers may cause infinite loops, such as below. | |||
There was a problem hiding this comment.
What is the behavior that you are trying to clarify here? This is example seems very similar to generic:
const obj = {
m: () => {
obj.m();
}
};
obj.m();where you would end up with infinite recursion.
|
Closing as part of incoming PRs clean up. Feel free to reopen when you get back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code example and caution note to alert of
expect.extend()mutability, with a code example, as mentioned in #32271.