Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools/*,scripts/*): enable nx plugins with project crystal for non production projects #32337

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Aug 19, 2024

Previous Behavior

  • we don't use any nx functionality for actual task execution ( jest/gulp only )

New Behavior

future of our monorepo setup is via inferred project targets ( project crystal ) - https://nx.dev/concepts/inferred-tasks#inferred-tasks-project-crystal

This PR enables inferred projects for all projects within scripts/ and tools/ for initial testing. Once proved valid and bug free all v9 projects will be migrated as well.

These changes are also a breaking change:

  • yarn workspace <package-name> <npm-script-alias> won't work anymore for test and lint targets
  • nx run becomes the only/unified option how to run things

Related Issue(s)

@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 19, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

📊 Bundle size report

✅ No changes found

nx.json Outdated Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 79 77 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 656 644 5000
Button mount 317 298 5000
Field mount 1108 1139 5000
FluentProvider mount 724 710 5000
FluentProviderWithTheme mount 88 96 10
FluentProviderWithTheme virtual-rerender 39 40 10
FluentProviderWithTheme virtual-rerender-with-unmount 79 77 10 Possible regression
MakeStyles mount 860 850 50000
Persona mount 1754 1762 5000
SpinButton mount 1412 1407 5000
SwatchPicker mount 1653 1640 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 121 107 1.13:1
PortalMinimalPerf.default 92 82 1.12:1
AttachmentMinimalPerf.default 90 81 1.11:1
ButtonMinimalPerf.default 89 80 1.11:1
InputMinimalPerf.default 582 539 1.08:1
RadioGroupMinimalPerf.default 266 247 1.08:1
DividerMinimalPerf.default 216 201 1.07:1
TreeWith60ListItems.default 92 86 1.07:1
BoxMinimalPerf.default 208 196 1.06:1
GridMinimalPerf.default 190 180 1.06:1
TextAreaMinimalPerf.default 297 281 1.06:1
AccordionMinimalPerf.default 87 83 1.05:1
AttachmentSlotsPerf.default 662 629 1.05:1
ImageMinimalPerf.default 229 219 1.05:1
FlexMinimalPerf.default 163 157 1.04:1
HeaderSlotsPerf.default 474 457 1.04:1
ListNestedPerf.default 324 312 1.04:1
ListWith60ListItems.default 372 356 1.04:1
SegmentMinimalPerf.default 195 187 1.04:1
TableMinimalPerf.default 238 228 1.04:1
CardMinimalPerf.default 312 304 1.03:1
ChatDuplicateMessagesPerf.default 155 150 1.03:1
DropdownManyItemsPerf.default 402 389 1.03:1
LayoutMinimalPerf.default 207 201 1.03:1
LoaderMinimalPerf.default 200 194 1.03:1
ProviderMergeThemesPerf.default 662 645 1.03:1
ProviderMinimalPerf.default 212 206 1.03:1
SliderMinimalPerf.default 754 735 1.03:1
StatusMinimalPerf.default 392 380 1.03:1
IconMinimalPerf.default 391 380 1.03:1
AnimationMinimalPerf.default 302 295 1.02:1
CarouselMinimalPerf.default 273 268 1.02:1
ChatMinimalPerf.default 434 424 1.02:1
DatepickerMinimalPerf.default 3621 3551 1.02:1
ItemLayoutMinimalPerf.default 718 704 1.02:1
ReactionMinimalPerf.default 208 204 1.02:1
SkeletonMinimalPerf.default 203 199 1.02:1
ButtonSlotsPerf.default 330 328 1.01:1
DropdownMinimalPerf.default 1436 1424 1.01:1
EmbedMinimalPerf.default 1891 1876 1.01:1
FormMinimalPerf.default 228 226 1.01:1
LabelMinimalPerf.default 218 216 1.01:1
RosterPerf.default 1553 1544 1.01:1
PopupMinimalPerf.default 357 354 1.01:1
TreeMinimalPerf.default 487 484 1.01:1
CheckboxMinimalPerf.default 1142 1138 1:1
DialogMinimalPerf.default 441 440 1:1
ListMinimalPerf.default 305 306 1:1
MenuMinimalPerf.default 498 499 1:1
MenuButtonMinimalPerf.default 954 950 1:1
SplitButtonMinimalPerf.default 2262 2267 1:1
TableManyItemsPerf.default 1092 1097 1:1
ToolbarMinimalPerf.default 539 540 1:1
TextMinimalPerf.default 189 191 0.99:1
CustomToolbarPrototype.default 1456 1476 0.99:1
VideoMinimalPerf.default 439 445 0.99:1
ListCommonPerf.default 372 378 0.98:1
TooltipMinimalPerf.default 1281 1301 0.98:1
ButtonOverridesMissPerf.default 656 674 0.97:1
AvatarMinimalPerf.default 103 108 0.95:1
ChatWithPopoverPerf.default 188 197 0.95:1
HeaderMinimalPerf.default 196 211 0.93:1
AlertMinimalPerf.default 142 163 0.87:1

nx.json Outdated Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 19, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 632 623 5000
Breadcrumb mount 1700 1713 1000
Checkbox mount 1695 1726 5000
CheckboxBase mount 1517 1481 5000
ChoiceGroup mount 2994 3054 5000
ComboBox mount 683 690 1000
CommandBar mount 6539 6558 1000
ContextualMenu mount 12357 12532 1000
DefaultButton mount 817 785 5000
DetailsRow mount 2196 2271 5000
DetailsRowFast mount 2217 2212 5000
DetailsRowNoStyles mount 2066 2102 5000
Dialog mount 2780 2921 1000
DocumentCardTitle mount 227 229 1000
Dropdown mount 2060 1989 5000
FocusTrapZone mount 1123 1178 5000
FocusZone mount 1059 1072 5000
GroupedList mount 42366 42366 2
GroupedList virtual-rerender 20380 20344 2
GroupedList virtual-rerender-with-unmount 52045 52343 2
GroupedListV2 mount 238 233 2
GroupedListV2 virtual-rerender 210 220 2
GroupedListV2 virtual-rerender-with-unmount 230 239 2
IconButton mount 1126 1157 5000
Label mount 352 339 5000
Layer mount 2782 2749 5000
Link mount 398 412 5000
MenuButton mount 967 988 5000
MessageBar mount 21422 21331 5000
Nav mount 2052 2069 1000
OverflowSet mount 821 771 5000
Panel mount 1906 1803 1000
Persona mount 757 757 1000
Pivot mount 928 923 1000
PrimaryButton mount 927 937 5000
Rating mount 4686 4683 5000
SearchBox mount 952 947 5000
Shimmer mount 1866 1885 5000
Slider mount 1362 1377 5000
SpinButton mount 3052 3067 5000
Spinner mount 380 400 5000
SplitButton mount 1893 1885 5000
Stack mount 416 421 5000
StackWithIntrinsicChildren mount 867 885 5000
StackWithTextChildren mount 2776 2808 5000
SwatchColorPicker mount 6388 6279 5000
TagPicker mount 1488 1458 5000
Text mount 392 383 5000
TextField mount 961 959 5000
ThemeProvider mount 853 868 5000
ThemeProvider virtual-rerender 596 584 5000
ThemeProvider virtual-rerender-with-unmount 1288 1310 5000
Toggle mount 626 633 5000
buttonNative mount 200 187 5000

@Hotell Hotell force-pushed the nx/enable-gradual-plugins branch from f856406 to 4184ea9 Compare August 19, 2024 12:29
@Hotell Hotell changed the title Nx/enable gradual plugins chore(tools/*): enable nx plugins with project crystal for non production projects Aug 19, 2024
@Hotell Hotell changed the title chore(tools/*): enable nx plugins with project crystal for non production projects chore(tools/*,scripts/*): enable nx plugins with project crystal for non production projects Aug 21, 2024
nx.json Show resolved Hide resolved
@Hotell Hotell mentioned this pull request Aug 21, 2024
39 tasks
@Hotell Hotell marked this pull request as ready for review August 21, 2024 13:10
@Hotell Hotell requested review from a team as code owners August 21, 2024 13:10
nx.json Show resolved Hide resolved
nx.json Show resolved Hide resolved
nx.json Show resolved Hide resolved
@Hotell Hotell requested a review from dmytrokirpa August 22, 2024 12:03
@Hotell Hotell merged commit 3b62661 into microsoft:master Aug 23, 2024
23 checks passed
@Hotell Hotell deleted the nx/enable-gradual-plugins branch August 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants