Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts-storybook): make getPackageStoriesGlob properly resolve stories paths based on new project.json#name pattern #31940

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 8, 2024

Previous Behavior

introduced #31893

sub-package stories are not rendered within public-docsite-v9 storybook

New Behavior

sub-package stories are rendered within public-docsite-v9 storybook

Related Issue(s)

…tories paths based on new project.json#name pattern
@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 8, 2024
@Hotell Hotell marked this pull request as ready for review July 8, 2024 14:09
@Hotell Hotell requested a review from a team as a code owner July 8, 2024 14:09
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell merged commit fe2ad5b into microsoft:master Jul 8, 2024
18 checks passed
@Hotell Hotell deleted the nx/fix/storybook-glob-mismatch branch July 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants