Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arg callout in substring expansion (bash) #1307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomkaragounis
Copy link
Contributor

Noticed that custom build flags were not being correctly assigned to the CUSTOM_CMAKE_CXX_FLAG variable in the build.sh script. Not sure how this got modified as I would still expect $1 to contain the full arg. Works with below fix.

Error examples:
./build.sh CUSTOM_BUILD_FLAGS="-DHAVE_MAT_EVT_TRACEID=1" debug
Current directory: /home/tomkar
BUILD_TYPE = Debug
Using current machine MAC_ARCH = x86_64
custom build flags = ""

./build.sh CUSTOM_BUILD_FLAGS -DHAVE_MAT_EVT_TRACEID=1 debug
Current directory: /home/tomkar
BUILD_TYPE = Debug
Using current machine MAC_ARCH = x86_64
custom build flags = "EID=1"

"EID=1" is 19 chars into -DHAVE_MAT_EVT_TRACEID=1, so offset is activated here, just for the next argument instead of the CUSTOM_BUILD_FLAGS

@tomkaragounis tomkaragounis requested a review from a team as a code owner November 4, 2024 22:44
@ThomsonTan
Copy link
Contributor

As we expect ${1} should match $PARAM1, could we try to understand why and how it is modified?

@tomkaragounis
Copy link
Contributor Author

As we expect ${1} should match $PARAM1, could we try to understand why and how it is modified?

I am actually not very well versed in bash, so I do not understand why the behavior is not working correctly. I have been testing it out locally and realized the problem when I try adding my own custom args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants