Fix arg callout in substring expansion (bash) #1307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that custom build flags were not being correctly assigned to the CUSTOM_CMAKE_CXX_FLAG variable in the build.sh script. Not sure how this got modified as I would still expect $1 to contain the full arg. Works with below fix.
Error examples:
./build.sh CUSTOM_BUILD_FLAGS="-DHAVE_MAT_EVT_TRACEID=1" debug
Current directory: /home/tomkar
BUILD_TYPE = Debug
Using current machine MAC_ARCH = x86_64
custom build flags = ""
./build.sh CUSTOM_BUILD_FLAGS -DHAVE_MAT_EVT_TRACEID=1 debug
Current directory: /home/tomkar
BUILD_TYPE = Debug
Using current machine MAC_ARCH = x86_64
custom build flags = "EID=1"
"EID=1" is 19 chars into -DHAVE_MAT_EVT_TRACEID=1, so offset is activated here, just for the next argument instead of the CUSTOM_BUILD_FLAGS