optimize regular expression creation in NpmComponentDetector (#1177)

* optimize regular expression creation in NpmComponentDetector * optimize regular expression creation in NpmComponentDetector * Update src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentDetector.cs Co-authored-by: Coby Allred <[email protected]> --------- Co-authored-by: Coby Allred <[email protected]>
microsoft · Jun 19, 2024 · dafe527 · dafe527
1 parent 155b742
commit dafe527
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentDetector.cs b/src/Microsoft.ComponentDetection.Detectors/npm/NpmComponentDetector.cs
@@ -15,6 +15,8 @@ namespace Microsoft.ComponentDetection.Detectors.Npm;
 
 public class NpmComponentDetector : FileComponentDetector
 {
+    private static readonly Regex SingleAuthor = new Regex(@"^(?<name>([^<(]+?)?)[ \t]*(?:<(?<email>([^>(]+?))>)?[ \t]*(?:\(([^)]+?)\)|$)", RegexOptions.Compiled);
+
     public NpmComponentDetector(
         IComponentStreamEnumerableFactory componentStreamEnumerableFactory,
         IObservableDirectoryWalkerFactory walkerFactory,
@@ -114,9 +116,7 @@ private NpmAuthor GetAuthor(JToken authorToken, string packageName, string fileP
 
         string authorName;
         string authorEmail;
-        var authorSingleStringPattern = @"^(?<name>([^<(]+?)?)[ \t]*(?:<(?<email>([^>(]+?))>)?[ \t]*(?:\(([^)]+?)\)|$)";
-        var authorMatch = new Regex(authorSingleStringPattern).Match(authorString);
-
+        var authorMatch = SingleAuthor.Match(authorString);
         /*
          * for parsing author in Json Format
          * for e.g.