NuGetCommandV2 fails gracefully when used on ubuntu 24 without mono #20801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magleaso
requested changes
Jan 22, 2025
| "loc.messages.Warning_UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth." | ||
| "loc.messages.Warning_UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth.", | ||
| "loc.messages.LIB_WhichNotFound_Linux": "Unable to locate executable file: '%s'. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.", | ||
| "loc.messages.Error_IncompatibleUbuntuVersion": "Detected using an Ubuntu24 or newer agent without mono. This is incompatible with NuGetCommand@2. Please follow the directions here [link] for how to pin your agent to an older version of Ubuntu or install mono on your agent." |
There was a problem hiding this comment.
The first version to break is 22.04, not 24
| "loc.messages.Warning_UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth." | ||
| "loc.messages.Warning_UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth.", | ||
| "loc.messages.LIB_WhichNotFound_Linux": "Unable to locate executable file: '%s'. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.", | ||
| "loc.messages.Error_IncompatibleUbuntuVersion": "Detected using an Ubuntu24 or newer agent without mono. This is incompatible with NuGetCommand@2. Please follow the directions here [link] for how to pin your agent to an older version of Ubuntu or install mono on your agent." |
There was a problem hiding this comment.
One of the benefits of using a kb link is we can change it to say whatever we want, so don't refer to the contents of the document in the message. Just say something like "See [link] for more information"
magleaso
reviewed
Jan 22, 2025
| "loc.messages.Warning_UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth." | ||
| "loc.messages.Warning_UnsupportedServiceConnectionAuth": "The service connection does not use a supported authentication method. Please use a service connection with personal access token based auth.", | ||
| "loc.messages.LIB_WhichNotFound_Linux": "Unable to locate executable file: '%s'. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.", | ||
| "loc.messages.Error_IncompatibleUbuntuVersion": "Detected agent uses Ubuntu 22.04 or newer and could not find mono. See [link] for more information." |
There was a problem hiding this comment.
I think we could be a little more direct that not only did we detect the condition, but that it is causing a failure. Consider "The task has failed because you are using Ubuntu 22.04 without mono. See [link] for more information."
magleaso
reviewed
Jan 24, 2025
| const distribution = _parseLinuxDistribution(lbsContents); | ||
| if (distribution === 'Ubuntu') { | ||
| const version = parseFloat(_parseUbuntuVersion(lbsContents)); | ||
| if (version >= 22.04) { |
There was a problem hiding this comment.
I was mistaken I apologize. I'm not sure where I got 22.04 from. 24.04 should be the proper cutoff (though as long as we check for mono as well, it shouldn't be a big deal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: NuGetCommandV2
Description: NuGetCommandV2 fails gracefully when used on ubuntu 24 without mono
Documentation changes required: (Y/N) Y - Documentation explaining ubuntu 24 is incompatible without mono and different options users can do instead
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y - Work Item #2244271
Checklist: