feat: Change async input strategy (#5060)

python/packages/autogen-agentchat/pyproject.toml

@@ -16,7 +16,6 @@ classifiers = [
 ]
 dependencies = [
     "autogen-core==0.4.1",
-    "aioconsole>=0.8.1"
 ]
 
 [tool.ruff]

python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py

@@ -5,7 +5,6 @@
 from inspect import iscoroutinefunction
 from typing import Any, AsyncGenerator, Awaitable, Callable, ClassVar, Generator, Optional, Sequence, Union, cast
 
-from aioconsole import ainput  # type: ignore
 from autogen_core import CancellationToken
 
 from ..base import Response
@@ -17,10 +16,9 @@
 InputFuncType = Union[SyncInputFunc, AsyncInputFunc]
 
 
-# TODO: ainput doesn't seem to play nicely with jupyter.
-#       No input window appears in this case.
+# TODO: check if using to_thread fixes this in jupyter
 async def cancellable_input(prompt: str, cancellation_token: Optional[CancellationToken]) -> str:
-    task: asyncio.Task[str] = asyncio.create_task(ainput(prompt))  # type: ignore
+    task: asyncio.Task[str] = asyncio.create_task(asyncio.to_thread(input, prompt))
     if cancellation_token is not None:
         cancellation_token.link_future(task)
     return await task

python/packages/autogen-agentchat/src/autogen_agentchat/ui/_console.py

@@ -5,7 +5,6 @@
 from inspect import iscoroutinefunction
 from typing import AsyncGenerator, Awaitable, Callable, Dict, List, Optional, TypeVar, Union, cast
 
-from aioconsole import aprint  # type: ignore
 from autogen_core import CancellationToken, Image
 from autogen_core.models import RequestUsage
 
@@ -70,6 +69,10 @@ def notify_event_received(self, request_id: str) -> None:
             self.input_events[request_id] = event
 
 
+def aprint(output: str, end: str = "\n") -> Awaitable[None]:
+    return asyncio.to_thread(print, output, end=end)
+
+
 async def Console(
     stream: AsyncGenerator[AgentEvent | ChatMessage | T, None],
     *,

python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py

@@ -30,13 +30,13 @@
     Image,
     MessageHandlerContext,
 )
-from autogen_core.models import FinishReasons
 from autogen_core.logging import LLMCallEvent
 from autogen_core.models import (
     AssistantMessage,
     ChatCompletionClient,
     ChatCompletionTokenLogprob,
     CreateResult,
+    FinishReasons,
     FunctionExecutionResultMessage,
     LLMMessage,
     ModelCapabilities,  # type: ignore

python/packages/magentic-one-cli/src/magentic_one_cli/_m1.py

@@ -3,7 +3,6 @@
 import warnings
 from typing import Optional
 
-from aioconsole import ainput  # type: ignore
 from autogen_agentchat.ui import Console, UserInputManager
 from autogen_core import CancellationToken
 from autogen_ext.models.openai import OpenAIChatCompletionClient
@@ -14,7 +13,7 @@
 
 
 async def cancellable_input(prompt: str, cancellation_token: Optional[CancellationToken]) -> str:
-    task: asyncio.Task[str] = asyncio.create_task(ainput(prompt))  # type: ignore
+    task: asyncio.Task[str] = asyncio.create_task(asyncio.to_thread(input, prompt))
     if cancellation_token is not None:
         cancellation_token.link_future(task)
     return await task