fix: Avoiding the creation of multiple output directories (#1171)

* Using iocTypes to avoid creating multiple instances of ADOTaskConfig * Fixing format issues Co-authored-by: Tania Martinez Villagomez <[email protected]>
microsoft · May 4, 2022 · 7c86844 · 7c86844
1 parent 9c21814
commit 7c86844
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/packages/ado-extension/src/ado-artifacts-info-provider.ts b/packages/ado-extension/src/ado-artifacts-info-provider.ts
@@ -1,13 +1,13 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
-import { ArtifactsInfoProvider } from '@accessibility-insights-action/shared';
+import { ArtifactsInfoProvider, iocTypes } from '@accessibility-insights-action/shared';
 import { inject, injectable } from 'inversify';
 
 import { ADOTaskConfig } from './task-config/ado-task-config';
 
 @injectable()
 export class ADOArtifactsInfoProvider extends ArtifactsInfoProvider {
-    constructor(@inject(ADOTaskConfig) private readonly adoTaskConfig: ADOTaskConfig) {
+    constructor(@inject(iocTypes.TaskConfig) private readonly adoTaskConfig: ADOTaskConfig) {
         super();
     }
     public getArtifactsUrl(): string | undefined {

diff --git a/packages/ado-extension/src/progress-reporter/console/ado-console-comment-creator.ts b/packages/ado-extension/src/progress-reporter/console/ado-console-comment-creator.ts
@@ -3,7 +3,7 @@
 
 import { ADOTaskConfig } from '../../task-config/ado-task-config';
 import { inject, injectable } from 'inversify';
-import { Logger, ReportConsoleLogConvertor } from '@accessibility-insights-action/shared';
+import { iocTypes, Logger, ReportConsoleLogConvertor } from '@accessibility-insights-action/shared';
 import * as fs from 'fs';
 import * as path from 'path';
 import { ReportMarkdownConvertor } from '@accessibility-insights-action/shared';
@@ -15,7 +15,7 @@ import { BaselineInfo } from '@accessibility-insights-action/shared';
 @injectable()
 export class AdoConsoleCommentCreator extends ProgressReporter {
     constructor(
-        @inject(ADOTaskConfig) private readonly taskConfig: ADOTaskConfig,
+        @inject(iocTypes.TaskConfig) private readonly taskConfig: ADOTaskConfig,
         @inject(ReportMarkdownConvertor) private readonly reportMarkdownConvertor: ReportMarkdownConvertor,
         @inject(ReportConsoleLogConvertor) private readonly reportConsoleLogConvertor: ReportConsoleLogConvertor,
         @inject(Logger) private readonly logger: Logger,

diff --git a/packages/ado-extension/src/progress-reporter/enforcement/workflow-enforcer.ts b/packages/ado-extension/src/progress-reporter/enforcement/workflow-enforcer.ts
@@ -3,15 +3,18 @@
 
 import { ADOTaskConfig } from '../../task-config/ado-task-config';
 import { inject, injectable } from 'inversify';
-import { Logger, ProgressReporter } from '@accessibility-insights-action/shared';
+import { iocTypes, Logger, ProgressReporter } from '@accessibility-insights-action/shared';
 import { CombinedReportParameters } from 'accessibility-insights-report';
 import { BaselineEvaluation } from 'accessibility-insights-scan';
 
 @injectable()
 export class WorkflowEnforcer extends ProgressReporter {
     private scanSucceeded = true;
 
-    constructor(@inject(ADOTaskConfig) private readonly adoTaskConfig: ADOTaskConfig, @inject(Logger) private readonly logger: Logger) {
+    constructor(
+        @inject(iocTypes.TaskConfig) private readonly adoTaskConfig: ADOTaskConfig,
+        @inject(Logger) private readonly logger: Logger,
+    ) {
         super();
     }
 

diff --git a/packages/ado-extension/src/progress-reporter/telemetry/telemetry-sender.ts b/packages/ado-extension/src/progress-reporter/telemetry/telemetry-sender.ts
@@ -10,7 +10,7 @@ import { BaselineEvaluation } from 'accessibility-insights-scan';
 @injectable()
 export class TelemetrySender extends ProgressReporter {
     constructor(
-        @inject(ADOTaskConfig) private readonly adoTaskConfig: ADOTaskConfig,
+        @inject(iocTypes.TaskConfig) private readonly adoTaskConfig: ADOTaskConfig,
         @inject(iocTypes.TelemetryClient) private readonly telemetryClient: TelemetryClient,
     ) {
         super();