-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hack Update] 036-BGP Replace NVA image due to vendor EOL, updates to most student and coach guides #933
Open
davmhelm
wants to merge
24
commits into
microsoft:master
Choose a base branch
from
davmhelm:036-BGP-Patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watch for non-AZ VPN Gateway SKU deprecation https://learn.microsoft.com/en-us/azure/vpn-gateway/gateway-sku-consolidation
* Hide warnings on deploy script [lines 39-40] * Update CSR scripts to C8000V config processes [lines 531-542] * Use latest encryption+integrity for phase1/phase2 (avoid deprecated options on CSR side) [lines 309-312, 318-321, 327-330, 336-339, 486-489, 494-497, 556-558, 566] * Clarified some debug output lines [lines 530, 618] * Added ServerAliveInterval option to ssh client per recommendation in Cisco docs (probably more important to use this in interactive connections later ;) )
* switch from NSGs assigned to NICs over to NSGs assigned to subnets * narrow scope of NSG rule permitting SSH in to your client's source IP * address situations where other automation might remove NSG rules allowing SSH in mid-script, which can leave lab deployment in an undefined state. Longer-term, could examine cloud-init custom-data scripts on CSR VM deployment, but I don't expect we'll be able to get away from heredoc configs entirely.
* Update SSH MAC proposals * Replace service used for finding "my" IPv4 public IP address * moved finding "my" IPv4 public IP address to reduce calls to the API service
Looks good to me! @microsoft/whatthehack-admins not sure how I can approve this one, I don't seem to have permissions. CC @davmhelm |
[heart] Dave Helm reacted to your message:
…________________________________
From: Jose Moreno ***@***.***>
Sent: Tuesday, December 24, 2024 10:34:55 AM
To: microsoft/WhatTheHack ***@***.***>
Cc: Dave Helm ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/WhatTheHack] [Hack Update] 036-BGP Replace NVA image due to vendor EOL, updates to most student and coach guides (PR #933)
Looks good to me! @microsoft/whatthehack-admins<https://github.com/orgs/microsoft/teams/whatthehack-admins> not sure how I can approve this one, I don't seem to have permissions.
CC @davmhelm<https://github.com/davmhelm>
—
Reply to this email directly, view it on GitHub<#933 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFASDLYGK35AG5KBLCEK7GL2HE2E7AVCNFSM6AAAAABT26XSKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQHE3DKNBUGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Cisco's End-of-Sale and End-of-Life for ISR 1000v, image availability has been pulled from Azure Marketplace. Recommended replacement is Cisco Catalyst 8000V series.
Changes made in lab: