Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable broken CodeQL query #61040

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Jan 24, 2025

To work around github/codeql#18584

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 24, 2025
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All we have to do is reject any PRs that add regexes. 😺

@jakebailey
Copy link
Member Author

"inputs that make TS run slow" are not things we consider security issues, so this is actually not a problem; its already the case the a user can just write a bunch of open parens and go slow too.

@jakebailey jakebailey merged commit d1e2e50 into microsoft:main Jan 24, 2025
32 checks passed
@jakebailey jakebailey deleted the disable-regexp-checking-codeql branch January 24, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants