-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AOT] Clean up some AOT issues in Advanced Paste module #36297
Open
moooyo
wants to merge
14
commits into
main
Choose a base branch
from
yuleng/AOT/AdvancedPaste
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ee1dba5
init
93fe40d
Do not update package version in this PR
4d428c8
Downgrade reverseMarkdown version
14a1bb6
Clean up some unnessesary change
046ab9a
Clean up unnessary change
839dba7
We can not mark AdvancedPaste is AOT compatible. We need to clean up …
5d814e0
merge main
ff532d0
Merge main and clean up new AOT build issue
dcd9603
Update LogEvent define.
fbef327
Add Kernal to spell check allow list.
eddcb1c
Update src/modules/AdvancedPaste/AdvancedPaste/Helpers/LogEvent.cs
moooyo 1aca55f
update typo bug
a362d33
Remove unused allow list item
699df28
Create a new folder to place source generation context
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
src/modules/AdvancedPaste/AdvancedPaste/Helpers/AdvancedPasteJsonSerializerContext.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// Copyright (c) Microsoft Corporation | ||
// The Microsoft Corporation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Text.Json.Serialization; | ||
using AdvancedPaste.Models.KernelQueryCache; | ||
|
||
namespace AdvancedPaste.Helpers; | ||
|
||
[JsonSerializable(typeof(PersistedCache))] | ||
[JsonSerializable(typeof(LogEvent))] | ||
[JsonSourceGenerationOptions(UseStringEnumConverter = true)] | ||
public sealed partial class AdvancedPasteJsonSerializerContext : JsonSerializerContext | ||
{ | ||
} |
21 changes: 21 additions & 0 deletions
21
src/modules/AdvancedPaste/AdvancedPaste/Helpers/LogEvent.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Copyright (c) Microsoft Corporation | ||
// The Microsoft Corporation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Text.Json; | ||
using AdvancedPaste.Models.KernelQueryCache; | ||
|
||
namespace AdvancedPaste.Helpers | ||
{ | ||
public class LogEvent | ||
{ | ||
public LogEvent(object message) | ||
{ | ||
this.message = message; | ||
} | ||
|
||
private object message; | ||
|
||
public string ToJsonString() => JsonSerializer.Serialize(this, AdvancedPasteJsonSerializerContext.Default.PersistedCache); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I believe the
LogEvent
class should be more defined.Since we know
telemetryEvent.CacheUsed
,telemetryEvent.IsSavedQuery
,telemetryEvent.PromptTokens
,telemetryEvent.CompletionTokens
,telemetryEvent.ModelName
,telemetryEvent.ActionChain
are the properties passed into the anonymous object, defining them in the class will make it cleaner and less prone to potential issues.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me consider how to make this interface easy to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snickler
I've updated the LogEvent define. Could you please take a look?