[SPIR-V] Fix bad OpLoad on loaded texture #6985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code path always added an OpLoad since it expected either an OpAccessChain or a variable. This is wrong if we get the texture from a called function. There is one thing I do find weird is the OpAccessChain result is considered to be an L-value. But I'd expect this to be an r-value. Fixes microsoft#4136 Signed-off-by: Nathan Gauër <[email protected]>
cassiebeckley
approved these changes
Oct 25, 2024
s-perron
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code path always added an OpLoad since it expected either an OpAccessChain or a variable.
This is wrong if we get the texture from a called function.
There is one thing I do find weird is the OpAccessChain result is considered to be an L-value. But I'd expect this to be an r-value.
Fixes #4136