Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dump] Fix PSV dump issues. #6881

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[Dump] Fix PSV dump issues. #6881

merged 3 commits into from
Aug 28, 2024

Conversation

python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Aug 27, 2024 •
edited
Loading

  1. Number of SemanticIndex should match number of rows instead of number of columns.
  2. Mesh shader could have ViewID mask for Primitive output.

For #6817.

@python3kgae
[Dump] Use number of rows when dump SemanticIndex.
79aca5a 
Number of SemanticIndex should match number of rows instead of number of columns.

For microsoft#6817.
@python3kgae python3kgae requested a review from a team as a code owner August 27, 2024 12:16
@python3kgae python3kgae changed the title [Dump] Use number of rows when dump SemanticIndex. [Dump] Fix PSV dump issues. Aug 27, 2024
@python3kgae python3kgae merged commit 6c99ecf into microsoft:main Aug 28, 2024
14 checks passed
@python3kgae python3kgae deleted the sig_dump_fix branch August 28, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bob80905 bob80905 bob80905 approved these changes

@damyanp damyanp damyanp approved these changes

@bogner bogner bogner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@python3kgae @bogner @damyanp @bob80905