-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor validate_template_version_patch method to use parent_service_template_name instead of parent_resource_id #3825
Conversation
…_template_name instead of parent_resource_id
Unit Test Results588 tests 588 ✅ 7s ⏱️ Results for commit ea9c03d. ♻️ This comment has been updated with latest results. |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7499784309 (with refid (in response to this comment from @marrobi) |
1 similar comment
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/7499784309 (with refid (in response to this comment from @marrobi) |
@marrobi Can you confirm the right issue is linked? I don't see the relationship between Key Vault secrets restore and this PR. |
It is now, sorry. |
/test-force-approve Passed: https://github.com/microsoft/AzureTRE/actions/runs/7499784309 |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit ea9c03d) (in response to this comment from @marrobi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests pass
Fixes #3824
This pull request refactors the validate_template_version_patch method in order to use the parent_service_template_name instead of the parent_resource_id. This was preventing user resource upgrades from working.