Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jr/17 linux guacamole issue when package mirror is stopped #3822

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Jan 5, 2024

Resolves #3811

What is being addressed

If a Linux VM is created while the Nexus package mirror VM is stopped, the Linux VM fails to create properly, meaning Guacamole connections to it fail.

When using the PowerShell start/stop scripts provided in the documentation on test environments, the start script does not restart the package mirror, leading to this issue.

How is this addressed

This change extends the start script, to start all VMs in the core resource group. It also aligns the PowerShell start script behaviour with the make tre-start behaviour, which already starts the core VMs.

@github-actions github-actions bot added the external PR from an external contributor label Jan 5, 2024
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi enabled auto-merge (squash) January 5, 2024 16:51
@marrobi
Copy link
Member

marrobi commented Jan 5, 2024

/test-force-approve docs only

@marrobi
Copy link
Member

marrobi commented Jan 5, 2024

@jonnyry can you fix the conflicts? Thanks.

Copy link

github-actions bot commented Jan 5, 2024

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 2c0ec1d)

(in response to this comment from @marrobi)

auto-merge was automatically disabled January 5, 2024 16:59

Head branch was pushed to by a user without write access

@jonnyry
Copy link
Collaborator Author

jonnyry commented Jan 5, 2024

@marrobi conflicts fixed

@marrobi marrobi enabled auto-merge (squash) January 5, 2024 17:02
@marrobi
Copy link
Member

marrobi commented Jan 5, 2024

/test-force-approve

Copy link

github-actions bot commented Jan 5, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 23e4798.

Copy link

github-actions bot commented Jan 5, 2024

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 23e4798)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 769ce02 into microsoft:main Jan 5, 2024
10 checks passed
@jonnyry jonnyry deleted the jr/17-linux-guacamole-issue branch April 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to connect to Linux VM through Guacamole
2 participants