Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for new OSS_REPO variable in AzureTRE-Deployment #3805

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Dec 1, 2023

Resolves microsoft/AzureTRE-Deployment#93

What is being addressed

Adding new OSS_REPO argument in devcontainer.json in the AzureTRE-Deployment repo to the TRE documentation, at the end of the following page:

https://microsoft.github.io/AzureTRE/v0.15.2/tre-admins/upgrading-tre/

This is matching documentation for PR microsoft/AzureTRE-Deployment#94

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and seems to work well. Thanks!

@marrobi
Copy link
Member

marrobi commented Dec 6, 2023

/test-force-approve

Docs only

Copy link

github-actions bot commented Dec 6, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit d25479a)

(in response to this comment from @marrobi)

Copy link

github-actions bot commented Dec 6, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit a435352.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member

marrobi commented Dec 6, 2023

@jonnyry can you fix the linting? Thanks.

@jonnyry
Copy link
Collaborator Author

jonnyry commented Dec 6, 2023

@marrobi fixed

@marrobi
Copy link
Member

marrobi commented Dec 6, 2023

/test-force-approve

Docs only

Copy link

github-actions bot commented Dec 6, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a435352)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) December 6, 2023 09:59
@marrobi marrobi merged commit b4e9977 into microsoft:main Dec 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterise the Azure TRE OSS repository location to allow easier repointing to fork
2 participants