Skip to content

Commit

Permalink
Linting
Browse files Browse the repository at this point in the history
  • Loading branch information
jonnyry committed Jan 7, 2025
1 parent e0753da commit e33f235
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions core/terraform/keyvault.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resource "azurerm_key_vault" "kv" {
network_acls {
default_action = local.kv_network_default_action
bypass = local.kv_network_bypass
ip_rules = [ local.myip ] # exception for deployment IP, this is removed in remove_deployment_network_exceptions.sh
ip_rules = [local.myip] # exception for deployment IP, this is removed in remove_deployment_network_exceptions.sh
}

lifecycle {
Expand All @@ -23,7 +23,7 @@ resource "azurerm_key_vault" "kv" {
# create provisioner required due to https://github.com/hashicorp/terraform-provider-azurerm/issues/18970
#
provisioner "local-exec" {
when = create
when = create
command = <<EOT
az keyvault update --name ${local.kv_name} --public-network-access ${local.kv_public_network_access_enabled ? "Enabled" : "Disabled"} --default-action ${local.kv_network_default_action} --bypass ${local.kv_network_bypass} --output none
az keyvault network-rule add --name ${local.kv_name} --ip-address ${local.myip} --output none
Expand Down
6 changes: 3 additions & 3 deletions core/terraform/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ locals {
tre_deployment_network_exception_tag = "tre_deployment_network_exception"

# key vault variables
kv_name = "kv-${var.tre_id}"
kv_name = "kv-${var.tre_id}"
kv_public_network_access_enabled = true
kv_network_default_action = var.enable_local_debugging ? "Allow" : "Deny"
kv_network_bypass = "AzureServices"
kv_network_default_action = var.enable_local_debugging ? "Allow" : "Deny"
kv_network_bypass = "AzureServices"
}

0 comments on commit e33f235

Please sign in to comment.