Skip to content

Commit

Permalink
Block CosmosDB key authentication (#4175)
Browse files Browse the repository at this point in the history
Co-authored-by: Tamir Kamara <[email protected]>
  • Loading branch information
tamirkamara and Tamir Kamara authored Dec 9, 2024
1 parent 0e30b9b commit d718721
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ ENHANCEMENTS:
* Add partial (core resources only) support for customer managed keys ([#4141](https://github.com/microsoft/AzureTRE/issues/4142), [#4144](https://github.com/microsoft/AzureTRE/issues/4144))
* Update the Azure CLI version to 2.67.0 in dev container and vmss ([#4157](https://github.com/microsoft/AzureTRE/pull/4157))
* Move Github PR bot commands into main documentation ([#4167](https://github.com/microsoft/AzureTRE/pull/4167))
* Block Authentication with keys to CosmosDB SQL account ([#4175](https://github.com/microsoft/AzureTRE/pull/4175))

BUG FIXES:
- Update KeyVault references in API to use the version so Terraform cascades the update ([#4112](https://github.com/microsoft/AzureTRE/pull/4112))
Expand Down
17 changes: 9 additions & 8 deletions core/terraform/statestore.tf
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
resource "azurerm_cosmosdb_account" "tre_db_account" {
name = "cosmos-${var.tre_id}"
location = azurerm_resource_group.core.location
resource_group_name = azurerm_resource_group.core.name
offer_type = "Standard"
kind = "GlobalDocumentDB"
automatic_failover_enabled = false
ip_range_filter = "${local.azure_portal_cosmos_ips}${var.enable_local_debugging ? ",${local.myip}" : ""}"
tags = local.tre_core_tags
name = "cosmos-${var.tre_id}"
location = azurerm_resource_group.core.location
resource_group_name = azurerm_resource_group.core.name
offer_type = "Standard"
kind = "GlobalDocumentDB"
automatic_failover_enabled = false
ip_range_filter = "${local.azure_portal_cosmos_ips}${var.enable_local_debugging ? ",${local.myip}" : ""}"
local_authentication_disabled = true
tags = local.tre_core_tags

dynamic "capabilities" {
# We can't change an existing cosmos
Expand Down
2 changes: 1 addition & 1 deletion core/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.11.5"
__version__ = "0.11.6"

0 comments on commit d718721

Please sign in to comment.