Fix logic and typo

microsoft · Oct 25, 2023 · 1b4afa7 · 1b4afa7
1 parent 8e5d967
commit 1b4afa7
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/api_app/_version.py b/api_app/_version.py
@@ -1 +1 @@
-__version__ = "0.15.19"
+__version__ = "0.15.20"
diff --git a/api_app/services/schema_service.py b/api_app/services/schema_service.py
@@ -50,15 +50,15 @@ def enrich_template(original_template, extra_properties, is_update: bool = False
     # this will help the UI render fields appropriately and know what it can send in a PATCH
     if is_update:
         for prop in template["properties"].values():
-            if not prop.get("updateable", True):
+            if not prop.get("updateable", False):
                 prop["readOnly"] = True
 
         if "allOf" in template:
             for conditional_property in template["allOf"]:
                 for condition in ["then", "else"]:
                     if condition in conditional_property and "properties" in conditional_property[condition]:
                         for prop in conditional_property[condition]["properties"].values():
-                            if not prop.get("updateable", True):
+                            if not prop.get("updateable", False):
                                 prop["readOnly"] = True
 
     # if there is an 'allOf' property which is empty, the validator fails - so remove the key

diff --git a/templates/workspaces/base/porter.yaml b/templates/workspaces/base/porter.yaml
@@ -1,7 +1,7 @@
 ---
 schemaVersion: 1.0.0
 name: tre-workspace-base
-version: 1.5.1
+version: 1.5.2
 description: "A base Azure TRE workspace"
 dockerfile: Dockerfile.tmpl
 registry: azuretre

diff --git a/templates/workspaces/base/template_schema.json b/templates/workspaces/base/template_schema.json
@@ -209,14 +209,14 @@
             "type": "string",
             "title": "Application (Client) ID",
             "description": "The AAD Application Registration ID for the workspace.",
-            "updatable": true
+            "updateable": true
           },
           "client_secret": {
             "type": "string",
             "title": "Application (Client) Secret",
             "description": "The AAD Application Registration secret for the workspace. This value will be stored in the Workspace Key Vault.",
             "sensitive": true,
-            "updatable": true
+            "updateable": true
           }
         },
         "required": [

diff --git a/templates/workspaces/unrestricted/porter.yaml b/templates/workspaces/unrestricted/porter.yaml
@@ -1,7 +1,7 @@
 ---
 schemaVersion: 1.0.0
 name: tre-workspace-unrestricted
-version: 0.11.3
+version: 0.11.4
 description: "A base Azure TRE workspace"
 dockerfile: Dockerfile.tmpl
 registry: azuretre

diff --git a/templates/workspaces/unrestricted/template_schema.json b/templates/workspaces/unrestricted/template_schema.json
@@ -207,14 +207,14 @@
             "type": "string",
             "title": "Application (Client) ID",
             "description": "The AAD Application Registration ID for the workspace.",
-            "updatable": true
+            "updateable": true
           },
           "client_secret": {
             "type": "string",
             "title": "Application (Client) Secret",
             "description": "The AAD Application Registration secret for the workspace. This value will be stored in the Workspace Key Vault.",
             "sensitive": true,
-            "updatable": true
+            "updateable": true
           }
         },
         "required": [