Skip to content

Commit

Permalink
esp32c2: Remove esp8684 alias
Browse files Browse the repository at this point in the history
  • Loading branch information
radimkarnis committed May 3, 2022
1 parent 0876fee commit af4bf3c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
3 changes: 1 addition & 2 deletions esptool/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
FatalError,
NotImplementedInROMError,
flash_size_bytes,
format_chip_name,
)


Expand Down Expand Up @@ -99,7 +98,7 @@ def main(argv=None, esp=None):
"--chip",
"-c",
help="Target chip type",
type=format_chip_name, # support ESP32-S2, etc.
type=lambda c: c.lower().replace("-", ""), # support ESP32-S2, etc.
choices=["auto"] + CHIP_LIST,
default=os.environ.get("ESPTOOL_CHIP", "auto"),
)
Expand Down
12 changes: 0 additions & 12 deletions esptool/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,6 @@ def mask_to_shift(mask):
return shift


def format_chip_name(c):
"""Normalize chip name from user input"""
c = c.lower().replace("-", "")
if c == "esp8684": # TODO: Delete alias, ESPTOOL-389
print(
"WARNING: Chip name ESP8684 is deprecated in favor of ESP32-C2 "
"and will be removed in a future release. Using ESP32-C2 instead."
)
return "esp32c2"
return c


def div_roundup(a, b):
"""Return a/b rounded up to nearest integer,
equivalent result to int(math.ceil(float(int(a)) / float(int(b))), only
Expand Down

0 comments on commit af4bf3c

Please sign in to comment.