* Allow TERM before commas in function application #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for forms such as: ```coffee console.log 1, 2: 3 , 4: 5 , 6 ```
Supports the following forms (as generated by e.g. js2coffee):
console.log(1,
name: name
, 2)
console.log(
name: name
, 4)
console.log(name: name
, 8)
And also this form with arbitrary indent/dedent around commas:
console.log(1,
2,
4,
)
f(
1
2
3
)
Because d:DEDENT t1:TERMINATOR? is already part of argumentListContents,
there's no need to specify them again before the closing paren.
| @@ -398,26 +398,33 @@ leftHandSideExpression = callExpression / newExpression | |||
| }; | |||
| } | |||
| argumentListContents | |||
| = e:argument es:(_ ("," / TERMINATOR) _ argument)* t:("," / TERMINATOR)? { | |||
| = e:argument es:(_ (TERM? _ "," _ TERMINATOR? INDENT* / TERMINATOR) _ argument DEDENT*)* t:("," _ DEDENT* TERMINATOR? / TERMINATOR)? { | |||
There was a problem hiding this comment.
This is too permissive, allowing unbalanced indentation. Please refactor in a way that forces matching indent/dedent markers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This patch allows TERM before commas between argument lists, which addresses #63 + #57 and greens the tests for:
I've also factored out
secondaryArgumentRestwhich subsumes implicit object literals, allowing for:Sanity check / feedback welcome!