Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ?tex command #371

Merged
merged 3 commits into from
Mar 23, 2021
Merged

add ?tex command #371

merged 3 commits into from
Mar 23, 2021

Conversation

thxo
Copy link
Contributor

@thxo thxo commented Mar 20, 2021

Description

Adds ?tex (alias ?latex), LaTeX rendering using the rTex project.

Fixes #65

Merge concurrently with miaowware/qrm-resources#38

Type of change

  • New feature

How has this been tested?

Manually tested using well-formed and invalid TeX expressions (examples).

Checklist

  • Issue exists for PR
  • Code reviewed by the author
  • Code documented (comments or other documentation)
  • Changes tested
  • All tests pass (see DEVELOPING.md, if it exists)
  • CHANGELOG.md updated if needed
  • Informative commit messages
  • Descriptive PR title

@thxo thxo marked this pull request as draft March 20, 2021 00:30
@thxo thxo marked this pull request as ready for review March 20, 2021 00:46
@classabbyamp classabbyamp added the enhancement New feature or request label Mar 20, 2021
@thxo thxo force-pushed the tex branch 2 times, most recently from 9d5c5db to 186afc7 Compare March 20, 2021 23:58
CHANGELOG.md Show resolved Hide resolved
exts/tex.py Outdated Show resolved Hide resolved
@classabbyamp
Copy link
Member

classabbyamp commented Mar 22, 2021

oh yeah another thing, should there be an option to invert the output, so it's closer to discord's dark theme (i.e. #2C2F33 background and white text)? If so, it may work better as a second PR.

classabbyamp
classabbyamp previously approved these changes Mar 22, 2021
@thxo
Copy link
Contributor Author

thxo commented Mar 22, 2021

oh yeah another thing, should there be an option to invert the output, so it's closer to discord's dark theme (i.e. #2C2F33 background and white text)? If so, it may work better as a second PR.

I think the best way is probably to use something like PIL to invert the colors, instead of doing it in the LaTeX template, so that we could invert colors for borders in tables or tikz graphics as well.

Doing it in a second PR sounds good.

@classabbyamp
Copy link
Member

hmmm with PIL it might not work well because of aliasing. Something to experiment with. #373

exts/tex.py Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
exts/tex.py Outdated Show resolved Hide resolved
@classabbyamp classabbyamp merged commit 4e572fa into miaowware:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return of the tex cmd?
3 participants