Reject attach launch configurations (#79)

* Aborting when 'attach' run configuration is detected * Lint fix * Changelog entry
metalbear-co · Oct 17, 2023 · bbdc8c7 · bbdc8c7
1 parent cecb168
commit bbdc8c7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/changelog.d/+reject-attach.fixed.md b/changelog.d/+reject-attach.fixed.md
@@ -0,0 +1 @@
+mirrord now shows an error notification when the user tries to use it with an `attach` launch configuration.
diff --git a/src/debugger.ts b/src/debugger.ts
@@ -95,6 +95,13 @@ async function main(
 		return config;
 	}
 
+	if (config.request === "attach") {
+		new NotificationBuilder()
+			.withMessage("mirrord cannot be used with `attach` launch configurations")
+			.error();
+		return null;
+	}
+
 	// For some reason resolveDebugConfiguration runs twice for Node projects. __parentId is populated.
 	if (config.__parentId || config.env?.["__MIRRORD_EXT_INJECTED"] === 'true') {
 		return config;

diff --git a/src/tests/e2e.ts b/src/tests/e2e.ts
@@ -42,7 +42,7 @@ describe("mirrord sample flow test", function () {
         try {
             await ew.closeEditor('Welcome');
         } catch (error) {
-            console.log("Welcome page is not displayed" + error)
+            console.log("Welcome page is not displayed" + error);
             // continue - Welcome page is not displayed
         }
         await ew.openEditor('app_flask.py');
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		mirrord now shows an error notification when the user tries to use it with an `attach` launch configuration.