Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove metal3datatemplate template reference #2265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Jan 23, 2025

What this PR does / why we need it: This reverts #184 #190 and any other mention of the templateReference. It's unclear if there is any use cases for templateReference. If there are none it should be deleted.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #1357

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adilghaffardev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2025
@peppi-lotta
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main-remediation metal3-centos-e2e-feature-test-main-remediation

@metal3-io-bot
Copy link
Contributor

@peppi-lotta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-feature-test-main-remediation bdf965d link false /test metal3-centos-e2e-feature-test-main-remediation
metal3-ubuntu-e2e-feature-test-main-remediation bdf965d link false /test metal3-ubuntu-e2e-feature-test-main-remediation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Contributor

@peppi-lotta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-feature-test-main-remediation bdf965d link false /test metal3-centos-e2e-feature-test-main-remediation
metal3-ubuntu-e2e-feature-test-main-remediation bdf965d link false /test metal3-ubuntu-e2e-feature-test-main-remediation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants