Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update clusterctl tests for 1.9 #2242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Jan 14, 2025

What this PR does / why we need it:
Update clusterctl tests for 1.9. and minor refactoring.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2241

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from adilghaffardev. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2025
@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from 6f6cb9f to 35c4203 Compare January 14, 2025 09:58
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from 35c4203 to c8bb16d Compare January 14, 2025 11:02
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from c8bb16d to 8a1822c Compare January 14, 2025 11:17
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@@ -98,11 +98,13 @@ source "${M3_DEV_ENV_PATH}/lib/ironic_tls_setup.sh"
BMO_OVERLAYS=(
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 0.6 be removed if we remove 1.7 ?

@@ -98,11 +98,13 @@ source "${M3_DEV_ENV_PATH}/lib/ironic_tls_setup.sh"
BMO_OVERLAYS=(
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.6"
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.8"
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.9"
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-latest"
)
IRONIC_OVERLAYS=(
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-25.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, should 25.0 be removed?

Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@adilGhaffarDev adilGhaffarDev force-pushed the update-clusterctl-test-1.9/adil branch from 8a1822c to 9146b4b Compare January 14, 2025 15:13
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2025
@adilGhaffarDev
Copy link
Member Author

/test metal3-e2e-clusterctl-upgrade-test-main

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-e2e-clusterctl-upgrade-test-main 9146b4b link false /test metal3-e2e-clusterctl-upgrade-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-e2e-clusterctl-upgrade-test-main 9146b4b link false /test metal3-e2e-clusterctl-upgrade-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BMO 0.9 and Ironic 27.0 are missing from CAPM3 e2e overlays
3 participants