🌱 Only use Kustomize to install Ironic and BMO in e2e tests #2240
Conversation
metal3-io-bot
added
the
size/L
|
/cc @lentzi90 @Sunnatillo |
mquhuy
force-pushed
the
mquhuy/use-kustomize-to-install-ironic-bmo-pivot-test
branch
2 times, most recently
from
9299a51 to
6907aa5
Compare
|
/test ? |
|
@adilGhaffarDev: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal3-centos-e2e-feature-test-main-pivoting |
mquhuy
force-pushed
the
mquhuy/use-kustomize-to-install-ironic-bmo-pivot-test
branch
from
6907aa5 to
0f01e04
Compare
|
/test metal3-centos-e2e-feature-test-main-pivoting |
mquhuy
force-pushed
the
mquhuy/use-kustomize-to-install-ironic-bmo-pivot-test
branch
from
0f01e04 to
27f096b
Compare
|
/test metal3-centos-e2e-feature-test-main-pivoting |
test/e2e/pivoting.go
Outdated
| SpecName: input.SpecName, | ||
| } | ||
| bmoKustomization := input.E2EConfig.GetVariable("BMO_RELEASE_LATEST") | ||
| By(fmt.Sprintf("Installing BMO from kustomization %s on the upgrade cluster", bmoKustomization)) |
There was a problem hiding this comment.
"Upgrade cluster" is confusing to me. We call it bootstrap or source cluster in other places so I would suggest changing to that.
| By(fmt.Sprintf("Installing BMO from kustomization %s on the upgrade cluster", bmoKustomization)) | |
| By(fmt.Sprintf("Installing BMO from kustomization %s on the bootstrap cluster", bmoKustomization)) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
mquhuy
force-pushed
the
mquhuy/use-kustomize-to-install-ironic-bmo-pivot-test
branch
from
27f096b to
d39dd27
Compare
|
/test metal3-centos-e2e-feature-test-main-pivoting |
|
/lgtm |
mquhuy
force-pushed
the
mquhuy/use-kustomize-to-install-ironic-bmo-pivot-test
branch
from
d39dd27 to
a35433c
Compare
|
New changes are detected. LGTM label has been removed. |
|
/test metal3-centos-e2e-feature-test-main-pivoting |
mquhuy
force-pushed
the
mquhuy/use-kustomize-to-install-ironic-bmo-pivot-test
branch
from
a35433c to
6c7aa37
Compare
Kustomize has been taken into use for upgrade test, but we didn't take it into use in pivoting tests. This PR takes kustomize into use everywhere, so that we can remove the custom installIronicBMO(). Signed-off-by: Huy Mai <[email protected]>
mquhuy
force-pushed
the
mquhuy/use-kustomize-to-install-ironic-bmo-pivot-test
branch
from
6c7aa37 to
7c25925
Compare
|
/test metal3-centos-e2e-feature-test-main-pivoting |
|
/test metal3-ubuntu-e2e-integration-test-main |
|
/retest |
1 similar comment
|
/retest |
|
@mquhuy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mquhuy: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Kustomize has been taken into use for upgrade test, but we didn't take it into use in pivoting tests. This PR takes kustomize into use everywhere, so that we can remove the custom installIronicBMO().