Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix issues in test links and triggers #1957

Merged
merged 1 commit into from
Sep 4, 2024
Merged

📖 Fix issues in test links and triggers #1957

merged 1 commit into from
Sep 4, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 4, 2024

This PR fixes minor issues in test link, test label and test name.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Sep 4, 2024

/retitle 📖 Fix issues in test links and triggers

@metal3-io-bot metal3-io-bot changed the title 📖 Fix minor issue in README 📖 Fix issues in test links and triggers Sep 4, 2024
tuminoid
tuminoid reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
Sunnatillo
Sunnatillo reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sunnatillo
Sunnatillo reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@Sunnatillo
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-7

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-centos-e2e-integration-test-release-1-7

In response to this:

/override metal3-centos-e2e-integration-test-release-1-7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 78b88f8 into metal3-io:release-1.7 Sep 4, 2024
17 of 18 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/update-job-trigger-release-1.7 branch September 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @tuminoid @metal3-io-bot @Sunnatillo