Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add e2e scalability test with fake systems #1954

Merged
merged 1 commit into from
Dec 19, 2024
Merged

🌱 Add e2e scalability test with fake systems #1954

merged 1 commit into from
Dec 19, 2024

Conversation

mboukhalfa
Copy link
Member

@mboukhalfa mboukhalfa commented Sep 3, 2024 •
edited by mquhuy
Loading

This PR introduces a scalability end-to-end test for CAPM3, applying multiple clusters using ClusterClass and reusing the existing ScaleSpec test framework from Cluster API (CAPI). The test is designed to simulate a large-scale environment with realistic configurations and is based on both FakeIPA and FKAS for authentication and endpoint management.

Test passed here: https://jenkins.nordix.org/view/Metal3/job/metal3-centos-e2e-scalability-test-main/9/console

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2024
@mboukhalfa
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-ubuntu-e2e-integration-test-main
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main-features
  • /test metal3-centos-e2e-feature-test-main-pivoting
  • /test metal3-centos-e2e-feature-test-main-remediation
  • /test metal3-e2e-1-29-1-30-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main-features
  • /test metal3-ubuntu-e2e-feature-test-main-pivoting
  • /test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • shellcheck
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

2 similar comments
@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@mquhuy
Copy link
Member

mquhuy commented Sep 19, 2024

@mboukhalfa We've been discussing on how to uncouple capm3 e2e from dev-env. Is it possible to design functions to run/configure fake-ipa in capm3, instead of relying on dev-env?

@mboukhalfa
Copy link
Member Author

/test metal3-centos-e2e-basic-test-main

@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from 5b00b35 to f6e58cb Compare September 19, 2024 12:06
@tuminoid
Copy link
Member

/retitle WIP: 🌱 Add scalablity test with fakeIPA
let's make it clear it is not intended to be merged as-is (points to private forks etc)

@metal3-io-bot metal3-io-bot changed the title 🌱 Add scalablity test with fakeIPA WIP: 🌱 Add scalablity test with fakeIPA Sep 20, 2024
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from f6e58cb to 977bb89 Compare September 26, 2024 10:13
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch 2 times, most recently from 6d26c4b to 50b7af2 Compare September 27, 2024 15:26
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2024
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch 8 times, most recently from 97777c8 to ab9a769 Compare October 7, 2024 12:53
@mboukhalfa mboukhalfa force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from ab9a769 to 5a400b3 Compare October 7, 2024 15:33
@mquhuy
Copy link
Member

mquhuy commented Dec 12, 2024

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

@mquhuy mquhuy force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from adbc994 to da0b27a Compare December 12, 2024 11:23
@mquhuy
Copy link
Member

mquhuy commented Dec 12, 2024

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

@mquhuy mquhuy force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from da0b27a to 70cbb85 Compare December 12, 2024 13:30
@mquhuy
Copy link
Member

mquhuy commented Dec 12, 2024 •
edited
Loading

The test passed here: https://jenkins.nordix.org/job/metal3-ubuntu-e2e-integration-test-main/724/console

@mquhuy
Copy link
Member

mquhuy commented Dec 12, 2024

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

@mquhuy
Copy link
Member

mquhuy commented Dec 17, 2024

/cc @lentzi90 @tuminoid @Rozzii @adilGhaffarDev

@mquhuy mquhuy force-pushed the Add-fakeIPA-e2e-test/mboukhalfa branch from 70cbb85 to 08eda7d Compare December 18, 2024 07:18
@mquhuy
Copy link
Member

mquhuy commented Dec 18, 2024

/unhold With CAPI 1.9.1, we no longer need local branch.

@mquhuy
Copy link
Member

mquhuy commented Dec 18, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@tuminoid
Copy link
Member

This will need rebase soon due CAPI/k8s bump hitting main. We should merge this anyways after 1.9 is cut?

@tuminoid tuminoid added this to the CAPM3 - v1.10 milestone Dec 18, 2024
@mquhuy
Copy link
Member

mquhuy commented Dec 18, 2024 •
edited
Loading

This will need rebase soon due CAPI/k8s bump hitting main. We should merge this anyways after 1.9 is cut?

I would say we can merge it right now. CAPM3 still has #2155 which is blocking 1.9.0. And rebasing is not needed, as we already have CAPI 1.9.1 in this PR.

@mquhuy
Copy link
Member

mquhuy commented Dec 18, 2024

Test passed here: https://jenkins.nordix.org/view/Metal3/job/metal3-centos-e2e-scalability-test-main/9/console

kashifest
kashifest reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Rozzii
Rozzii reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Let's see what happens.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@metal3-io-bot metal3-io-bot merged commit 6dee4bc into metal3-io:main Dec 19, 2024
21 checks passed
@metal3-io-bot metal3-io-bot deleted the Add-fakeIPA-e2e-test/mboukhalfa branch December 19, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@Rozzii Rozzii Rozzii left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
CAPM3 - v1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@mboukhalfa @metal3-io-bot @mquhuy @tuminoid @Rozzii @kashifest