Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump CAPI to v1.7.0-beta.0 #1530

Merged
merged 3 commits into from
Mar 21, 2024
Merged

🌱 Bump CAPI to v1.7.0-beta.0 #1530

merged 3 commits into from
Mar 21, 2024

Conversation

kashifest
Copy link
Member

Bumps CAPI to v1.7.0-beta.0 and prepare main branch for CAPI v1.7 contract.

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2024
@kashifest
Copy link
Member Author

Note for reviewers: This has an extra commit which will be removed once #1525 lands

@kashifest kashifest force-pushed the bump/capi-v1.7.0beta branch from 3e3694a to b91bc7c Compare March 18, 2024 13:46
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

1 similar comment
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@kashifest
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024
@kashifest kashifest force-pushed the bump/capi-v1.7.0beta branch from b91bc7c to de2989c Compare March 19, 2024 08:53
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2024
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

1 similar comment
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

@kashifest kashifest force-pushed the bump/capi-v1.7.0beta branch from a01fbd3 to 8a773c9 Compare March 19, 2024 09:46
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

1 similar comment
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

@kashifest kashifest force-pushed the bump/capi-v1.7.0beta branch from 8a773c9 to 802ff31 Compare March 19, 2024 10:17
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-integration-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-integration-main
/test-centos-e2e-integration-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-feature-main

1 similar comment
@kashifest
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@kashifest
Copy link
Member Author

/test-e2e-upgrade-main-from-release-1-6

1 similar comment
@kashifest
Copy link
Member Author

/test-e2e-upgrade-main-from-release-1-6

@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

1 similar comment
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-feature-main

@kashifest
Copy link
Member Author

/test-e2e-upgrade-main-from-release-1-6

1 similar comment
@kashifest
Copy link
Member Author

/test-e2e-upgrade-main-from-release-1-6

@kashifest
Copy link
Member Author

/test-e2e-upgrade-main-from-release-1-6
/test-e2e-upgrade-main-from-release-1-3

@kashifest
Copy link
Member Author

/test-e2e-upgrade-main-from-release-1-3

@kashifest
Copy link
Member Author

/test-ubuntu-e2e-feature-main

Sunnatillo
Sunnatillo reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 21, 2024
mboukhalfa
mboukhalfa reviewed Mar 21, 2024
View reviewed changes
scripts/ci-e2e.sh Outdated Show resolved Hide resolved
@kashifest kashifest force-pushed the bump/capi-v1.7.0beta branch from 76fb6f5 to 7c49888 Compare March 21, 2024 10:09
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2024
@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Mar 21, 2024 •
edited
Loading

@kashifest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
shellcheck 7c49888 link true /test shellcheck
test 7c49888 link true /test test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kashifest
Bump CAPI to v1.7.0-beta.0
dc79600 
Signed-off-by: Kashif Khan <[email protected]>
@kashifest
Prepare main branch for CAPI v1.7 contract
3fd5439 
Signed-off-by: Kashif Khan <[email protected]>
@kashifest
Get Machine using controlplane labels instead of names
1b5b166 
Starting from v1.7 metal3machines will inherit machine name and wont have strings like controlplane and worker in their names anymore.

Signed-off-by: Kashif Khan <[email protected]>
@kashifest kashifest force-pushed the bump/capi-v1.7.0beta branch from 7c49888 to 1b5b166 Compare March 21, 2024 10:12
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2024
Sunnatillo
Sunnatillo reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
@kashifest kashifest mentioned this pull request Mar 21, 2024
Merged
@mboukhalfa
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@tuminoid
Copy link
Member

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

1 similar comment
@kashifest
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@metal3-io-bot metal3-io-bot merged commit 0debe53 into metal3-io:main Mar 21, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the bump/capi-v1.7.0beta branch March 21, 2024 12:00
@Sunnatillo Sunnatillo mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@mboukhalfa mboukhalfa mboukhalfa left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kashifest @metal3-io-bot @mboukhalfa @tuminoid @Sunnatillo