🐛 EnsureImage download image fix #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
|
/test-centos-e2e-integration-main |
adilGhaffarDev
force-pushed
the
ensure-image-fix-download/adil
branch
from
d6b9d10 to
9c599ab
Compare
|
lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test-centos-e2e-integration-main /test-ubuntu-integration-main |
Signed-off-by: muhammad adil ghaffar <[email protected]>
adilGhaffarDev
force-pushed
the
ensure-image-fix-download/adil
branch
from
9c599ab to
b963e37
Compare
|
/test-centos-e2e-integration-main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When EnsureImage fails to download an image instead of giving the right error that the
image is not availableit downloads a failed page(https://artifactory.nordix.org/ui/native/metal3/images/k8s_v1.28.0/), and in provisioning ironic tries to use it. This PR is fixing this by erroring out the right message and also failing early instead of trying to provision with non existent image.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #