🌱 Bump CAPI to v1.6.2 #1475
🌱 Bump CAPI to v1.6.2 #1475
Conversation
metal3-io-bot
added
the
size/L
adilGhaffarDev
force-pushed
the
bump-capi-v1.6.2-on-1.6/adil
branch
2 times, most recently
from
72fbc10 to
c5a6232
Compare
metal3-io-bot
added
size/M
Signed-off-by: muhammad adil ghaffar <[email protected]>
adilGhaffarDev
force-pushed
the
bump-capi-v1.6.2-on-1.6/adil
branch
from
c5a6232 to
1a20bb2
Compare
| @@ -6,7 +6,7 @@ require ( | |||
| github.com/drone/envsubst v1.0.3 | |||
| github.com/golang/mock v1.6.0 | |||
| github.com/jteeuwen/go-bindata v3.0.7+incompatible | |||
| k8s.io/code-generator v0.29.0 | |||
There was a problem hiding this comment.
I am unsure why this was uplifted before. v0.29.0 requires go 1.21 and with k8s.io/code-generator v0.29.0 go mod tidy was changing the go version in hack tools to 1.21 and also adding toolchains . To make the go version consistent in all go.mods of the project I am changing it back to k8s.io/code-generator v0.28.1
There was a problem hiding this comment.
Interesting, that shouldn't have worked in the first place as you are explaining, since it is already v0.29.0 in release-1.6 branch without complains, anyhow keeping it to v0.28.1 is fine also.
|
/test-ubuntu-e2e-integration-release-1-6 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test-ubuntu-e2e-integration-release-1-6 |
|
/cc @lentzi90 @mboukhalfa |
What this PR does / why we need it:
as title
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #