Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fixing and simplifying clusterctl upgrade tests #1464

Merged
merged 1 commit into from
Apr 2, 2024
Merged

🌱 Fixing and simplifying clusterctl upgrade tests #1464

merged 1 commit into from
Apr 2, 2024

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
Fixing and simplifying clusterctl upgrade tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 20, 2024
@adilGhaffarDev
Copy link
Member Author

/hold until we have jjbs for this test

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2024
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-basic-test-release-1.6

1 similar comment
@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-basic-test-release-1.6

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test generate
  • /test gofmt
  • /test gomod
  • /test govet
  • /test manifestlint
  • /test markdownlint
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-centos-e2e-basic-test-release-1-6
  • /test metal3-ubuntu-e2e-basic-test-release-1-6

Use /test all to run the following jobs that were automatically triggered:

  • build
  • generate
  • gofmt
  • gomod
  • govet
  • manifestlint
  • unit

In response to this:

/test metal3-centos-e2e-basic-test-release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-basic-test-release-1-6

2 similar comments
@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-basic-test-release-1-6

@mboukhalfa
Copy link
Member

/test metal3-centos-e2e-basic-test-release-1-6

@adilGhaffarDev adilGhaffarDev force-pushed the fix_clusterctl_upgrade/adil branch from 09c6428 to 86bcd25 Compare March 28, 2024 09:31
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the fix_clusterctl_upgrade/adil branch 2 times, most recently from ff087c2 to 3fc76d8 Compare March 28, 2024 10:04
@adilGhaffarDev
Copy link
Member Author

test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev adilGhaffarDev force-pushed the fix_clusterctl_upgrade/adil branch from 3fc76d8 to 93bb603 Compare March 28, 2024 10:06
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-6

@adilGhaffarDev
Copy link
Member Author

/test-centos-e2e-integration-release-1-6

@adilGhaffarDev adilGhaffarDev force-pushed the fix_clusterctl_upgrade/adil branch from 93bb603 to 76a82c8 Compare March 28, 2024 10:14
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-6

@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-main

@tuminoid
Copy link
Member

/test-ubuntu-e2e-integration-release-1-6

@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev adilGhaffarDev force-pushed the fix_clusterctl_upgrade/adil branch from 76a82c8 to 325405a Compare March 28, 2024 10:57
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev adilGhaffarDev changed the title [wip]🌱 Fixing and simplifying clusterctl upgrade tests 🌱 Fixing and simplifying clusterctl upgrade tests Mar 28, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev adilGhaffarDev force-pushed the fix_clusterctl_upgrade/adil branch from 325405a to 7cff5db Compare March 28, 2024 11:36
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev adilGhaffarDev force-pushed the fix_clusterctl_upgrade/adil branch from 7cff5db to 649f796 Compare March 28, 2024 12:38
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

1 similar comment
@adilGhaffarDev
Copy link
Member Author

/test-e2e-clusterctl-upgrade-release-1-6

@adilGhaffarDev
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@tuminoid
Copy link
Member

tuminoid commented Apr 2, 2024

/test-ubuntu-e2e-integration-release-1-6

tuminoid
tuminoid reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@metal3-io-bot metal3-io-bot merged commit 33588ba into metal3-io:release-1.6 Apr 2, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the fix_clusterctl_upgrade/adil branch April 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@mboukhalfa mboukhalfa mboukhalfa approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adilGhaffarDev @mboukhalfa @metal3-io-bot @tuminoid