Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Take new release workflow into use #2171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Jan 8, 2025

This workflow does an automatic tag, build and push images for a custom release when the note of that release is merged into the main branch.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2025
Copy link
Member

@adilGhaffarDev adilGhaffarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in BMO we create bit different tags, we create tag for pkg/hardwareutils/ too and instead api/ in BMO we have apis/

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-new-release-workflow branch 3 times, most recently from d1efe61 to f48e63d Compare January 8, 2025 12:21
or a new patch release from the latest release branch, uncheck the box for
latest release. If it is a release candidate (RC) or a beta release,
tick pre-release box.
- Github action `build-images-action` is triggered once tags are pushed from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not correct

docs/releasing.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-new-release-workflow branch from f48e63d to d07616a Compare January 8, 2025 14:58
@tuminoid
Copy link
Member

tuminoid commented Jan 9, 2025

Let's wait until we iterate the release documentation wording here: metal3-io/cluster-api-provider-metal3#2218
then its easier to sync to here, and not having to review two similar PRs.
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@mquhuy mquhuy force-pushed the mquhuy/add-new-release-workflow branch from d07616a to 4882d47 Compare January 10, 2025 13:56
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

docs/releasing.md Outdated Show resolved Hide resolved
This workflow does an automatic tag, build and push images for a custom
release when the note of that release is merged into the main branch.

Signed-off-by: Huy Mai <[email protected]>
@mquhuy mquhuy force-pushed the mquhuy/add-new-release-workflow branch from 4882d47 to 48d30be Compare January 13, 2025 12:03
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @lentzi90

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@tuminoid
Copy link
Member

/unhold
Was waiting for settling discussion elsewhere.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants