-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Take new release workflow into use #2171
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in BMO we create bit different tags, we create tag for pkg/hardwareutils/
too and instead api/
in BMO we have apis/
d1efe61
to
f48e63d
Compare
docs/releasing.md
Outdated
or a new patch release from the latest release branch, uncheck the box for | ||
latest release. If it is a release candidate (RC) or a beta release, | ||
tick pre-release box. | ||
- Github action `build-images-action` is triggered once tags are pushed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct
f48e63d
to
d07616a
Compare
Let's wait until we iterate the release documentation wording here: metal3-io/cluster-api-provider-metal3#2218 |
d07616a
to
4882d47
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This workflow does an automatic tag, build and push images for a custom release when the note of that release is merged into the main branch. Signed-off-by: Huy Mai <[email protected]>
4882d47
to
48d30be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @lentzi90
/unhold |
This workflow does an automatic tag, build and push images for a custom release when the note of that release is merged into the main branch.