fix parsing of rating end points #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickeyn
previously approved these changes
May 14, 2024
haarg
force-pushed
the
haarg/fix-fake-rating
branch
4 times, most recently
from
37bec02 to
bccbdbe
Compare
The fake rating search end points need the Deserialize ActionClass to parse their body. Also, MetaCPAN::Client has a bug that prevents it from properly using its testing user agent, so just give the results for normal MC::C UAs.
haarg
force-pushed
the
haarg/fix-fake-rating
branch
from
bccbdbe to
6137a2a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
- Coverage 60.85% 60.78% -0.07%
==========================================
Files 163 163
Lines 4460 4460
Branches 649 649
==========================================
- Hits 2714 2711 -3
- Misses 1510 1516 +6
+ Partials 236 233 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake rating search end points need the Deserialize ActionClass to parse their body.
Also, MetaCPAN::Client has a bug that prevents it from properly using its testing user agent, so just give the results for normal MC::C UAs.