MBS-13896 / MBS-13897: User type link improvements #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc page was reorganized and improved, but that broke the links, since headers were changed to singular.
There's no real reason why we wouldn't link to the docs from here.
There's no real reason why we wouldn't link to the docs from here.
I can't see any good reason why we don't already show this, which will be even more relevant once admins are allowed to approve or reject all edits (MBS-13770).
reosarevok
added
QoL
|
THANKS AND SORRY XO |
mwiencek
approved these changes
Jan 10, 2025
| if (isAccountAdmin(user)) { | ||
| typesList.push( | ||
| <a href="/doc/Editor#Account_admin" key="account-admin"> | ||
| {lp('Account admin', 'user type')} |
There was a problem hiding this comment.
Just curious, are these [privileges] listed in any particular order? They don't seem to be sorted by power nor alphabetically. :)
There was a problem hiding this comment.
I have no idea why the existing order was what it is - my reasoning on the sorting of account admin was "auto-editor is the most relevant for a day-to-day user checking that, and after that account admin seems the most important due to the power it involves so I'll put it second" 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-13896 / Implement MBS-13897
Description
This fixes anchor links to editor types from editor pages (such as
/user/reosarevok), which had broken when @Aerozol changed the headers on the doc from plural to singular. It also adds links to missing (now documented) types, "Bot", "Beginner" and "Account admin" (the last of which wasn't even indicated on the page yet for some reason, but really should be).Testing
Manually, by checking my own page (all privs except beginner and bot) and creating a new account locally (beginner) and setting it as a bot.